Fix long-poll hang on ip change using KeepAliveConfig (Go 1.23) #206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This needs a rebase and DCO. This needs a DCO sign-off. You can use |
Signed-off-by: salahdevp <slhokli2002@gmail.com>
Contributor
Author
|
Done, rebased and added DCO |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue (#205) by replacing the old
KeepAliveconfig with the newKeepAliveConfig(introduced in Go 1.23), allowing more control over TCP keepalive behavior.Idle=30s,Interval=5s,Count=3→ total timeout 40s instead of the old 4m 30sThis change is to reduce the hang caused by the default TCP keepalive behavior when the client’s IP changes or connection gets interrupted.
Fixes: #205