cosmetic #9
Merged
cosmetic #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
There are several examples where upstream is subject to the same change as you emphasize here, e.g., https://github.com/libsdl-org/SDL/blob/98bed62259788a2f73ef2146afe6cde161a157db/CMakeLists.txt#L144 You should focus your energy over there instead. |
Contributor
Author
|
I stopped working on the upstream, only on own fork. If you find such issues there, just let me know. If you do not want this change, feel free to close it. |
john-tornblom
merged commit e0250b8
into
ps5-payload-dev:release-2.30.x-ps5
31 of 38 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.