Skip to content

Conversation

@YasenT
Copy link
Collaborator

@YasenT YasenT commented Jan 5, 2026

Summary by Sourcery

Enhancements:

  • Turn on the AUTHENTICATION_HEADER_DEBUG flag to allow inspection of authentication headers during runtime.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jan 5, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR enables authentication header debugging in the Pulp service configuration by turning on the AUTHENTICATION_HEADER_DEBUG setting in the application settings module.

File-Level Changes

Change Details Files
Enable authentication header debugging in application settings.
  • Set the AUTHENTICATION_HEADER_DEBUG configuration flag from False to True to allow inspection/logging of authentication headers in the running environment
pulp_service/pulp_service/app/settings.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 1 issue

Prompt for AI Agents
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location> `pulp_service/pulp_service/app/settings.py:10` </location>
<code_context>
 FEATURE_SERVICE_API_URL = "https://feature.stage.api.redhat.com/features/v1/featureStatus"
 FEATURE_SERVICE_API_CERT_PATH = ""
-AUTHENTICATION_HEADER_DEBUG = False
+AUTHENTICATION_HEADER_DEBUG = True
 INSTALLED_APPS = "@merge django.contrib.admin.apps.SimpleAdminConfig,hijack,hijack.contrib.admin"
 TEST_TASK_INGESTION = False
</code_context>

<issue_to_address>
**🚨 issue (security):** Reconsider enabling AUTHENTICATION_HEADER_DEBUG in non-local environments due to potential exposure of sensitive auth data.

This flag can leak authentication headers (tokens, cookies, API keys) via logs or debug output. If it’s only for local troubleshooting, please protect it with an environment variable or DEBUG-like setting so it cannot be enabled in staging/production by default.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@YasenT
Copy link
Collaborator Author

YasenT commented Jan 5, 2026

/retry

@YasenT
Copy link
Collaborator Author

YasenT commented Jan 5, 2026

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant