-
Notifications
You must be signed in to change notification settings - Fork 47
Fix migration to prepare for Django 5 #2152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| field=models.ManyToManyField( | ||
| through="container.ManifestListManifest", to="container.manifest" | ||
| ), | ||
| field=models.ManyToManyField(through='container.ManifestListManifest', through_fields=('image_manifest', 'manifest_list'), to='container.manifest'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can get away with this, because it isn't even a change to the schema in postgres. Just the internal Django state model was missing the 'trough_fields'.
And the migration coming later to fix this is just the same but also idempotent.
pedro-psb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The migration does not change the database schema, so we can safely backport.
# pulpcore-manager sqlmigrate container 0035
BEGIN;
--
-- Alter field content_ptr on blob
--
-- (no-op)
--
-- Alter field distribution_ptr on containerdistribution
--
-- (no-op)
--
-- Alter field pulp_id on containernamespace
--
-- (no-op)
--
-- Alter field manifest_signing_service on containerpushrepository
--
-- (no-op)
--
Backport to 2.20: 💚 backport PR created✅ Backport PR branch: Backported as #2153 🤖 @patchback |
Backport to 2.19: 💚 backport PR created✅ Backport PR branch: Backported as #2154 🤖 @patchback |
Backport to 2.22: 💚 backport PR created✅ Backport PR branch: Backported as #2155 🤖 @patchback |
Backport to 2.24: 💚 backport PR created✅ Backport PR branch: Backported as #2156 🤖 @patchback |
No description provided.