Skip to content

Conversation

@mdellweg
Copy link
Member

No description provided.

field=models.ManyToManyField(
through="container.ManifestListManifest", to="container.manifest"
),
field=models.ManyToManyField(through='container.ManifestListManifest', through_fields=('image_manifest', 'manifest_list'), to='container.manifest'),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can get away with this, because it isn't even a change to the schema in postgres. Just the internal Django state model was missing the 'trough_fields'.
And the migration coming later to fix this is just the same but also idempotent.

Copy link
Member

@pedro-psb pedro-psb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The migration does not change the database schema, so we can safely backport.

# pulpcore-manager sqlmigrate container 0035
BEGIN;
--
-- Alter field content_ptr on blob
--
-- (no-op)
--
-- Alter field distribution_ptr on containerdistribution
--
-- (no-op)
--
-- Alter field pulp_id on containernamespace
--
-- (no-op)
--
-- Alter field manifest_signing_service on containerpushrepository
--
-- (no-op)
--

@mdellweg mdellweg merged commit 83404a5 into pulp:2.26 Jan 13, 2026
13 checks passed
@patchback
Copy link

patchback bot commented Jan 13, 2026

Backport to 2.20: 💚 backport PR created

✅ Backport PR branch: patchback/backports/2.20/83404a556ede04381ef9066f704e0321243aa421/pr-2152

Backported as #2153

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback
Copy link

patchback bot commented Jan 13, 2026

Backport to 2.19: 💚 backport PR created

✅ Backport PR branch: patchback/backports/2.19/83404a556ede04381ef9066f704e0321243aa421/pr-2152

Backported as #2154

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback
Copy link

patchback bot commented Jan 13, 2026

Backport to 2.22: 💚 backport PR created

✅ Backport PR branch: patchback/backports/2.22/83404a556ede04381ef9066f704e0321243aa421/pr-2152

Backported as #2155

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback
Copy link

patchback bot commented Jan 13, 2026

Backport to 2.24: 💚 backport PR created

✅ Backport PR branch: patchback/backports/2.24/83404a556ede04381ef9066f704e0321243aa421/pr-2152

Backported as #2156

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants