change build_index function #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yu45020 Hi, I'm interested in building an open-source SEC scraper and downloader. Is it acceptable to utilize the function in this PR? Thanks! |
Author
|
@deji725 No problem. |
|
@yu45020 Thank you! I'll leave a comment to this PR under the build_index_sec function in my code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original function download and save the zipfile, process the tsv, and then remove the zipfile. Pandas can read tsv from zip file directly, so I download the master index and write it as a byte object in memory and fee into pandas's read_csv function.