Skip to content

Fix: Correct ValueError message for invalid ABI version #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dlech merged 1 commit into from
May 30, 2025
Merged

Fix: Correct ValueError message for invalid ABI version #108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pybricksdev/compile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ async def compile_file(
),
)
else:
raise ValueError("mpy_version must be 5")
raise ValueError("mpy_version must be 5 or 6")

proc.check_returncode()

Expand Down
15 changes: 15 additions & 0 deletions tests/test_compile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,3 +31,18 @@ async def test_compile_file(abi: int):
assert int_bits == 31
finally:
os.unlink(f.name)


@pytest.mark.asyncio
async def test_compile_file_invalid_abi():
with NamedTemporaryFile("w", delete=False) as f:
try:
f.write("print('test')")
f.close()

with pytest.raises(ValueError, match="mpy_version must be 5 or 6"):
await compile_file(
os.path.dirname(f.name), os.path.basename(f.name), abi=4
)
finally:
os.unlink(f.name)