Skip to content

Pytz dependency specification #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
fsoubelet wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Pytz dependency specification #111

fsoubelet wants to merge 5 commits into from
+61 −76

Conversation

@fsoubelet
Copy link
Member

@fsoubelet fsoubelet commented Jan 27, 2026

This package relies on pytz in the BSRT analysis script, which we were getting from our pandas dependency. Since pandas 3.0 it is an optional dependency for them.

A simple fix was to declare the option so we would get pytz when installing PyLHC. This should be a very simple merge and release.

@fsoubelet fsoubelet requested a review from jgray-19 January 27, 2026 14:51
@fsoubelet fsoubelet self-assigned this Jan 27, 2026
@fsoubelet fsoubelet added Type: Release Issue preparing for a release. Estimate: Easy Good first issue for newcomers. Straightforward fixes. Type: Maintenance Improvements in the code, that are not necessarily visible in functionality. Priority: Low Work on this if you have some spare time. Status: Review Needed Work currently stopped, untils someone else reviews it. labels Jan 27, 2026
@github-actions
Copy link

github-actions bot commented Jan 27, 2026

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  pylhc
  __init__.py
Project Total  

This report was generated by python-coverage-comment-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jgray-19 jgray-19 Awaiting requested review from jgray-19

At least 1 approving review is required to merge this pull request.

Assignees

@fsoubelet fsoubelet

Labels

Estimate: Easy Good first issue for newcomers. Straightforward fixes. Priority: Low Work on this if you have some spare time. Status: Review Needed Work currently stopped, untils someone else reviews it. Type: Maintenance Improvements in the code, that are not necessarily visible in functionality. Type: Release Issue preparing for a release.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fsoubelet