-
-
Notifications
You must be signed in to change notification settings - Fork 10
Split detections #539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Split detections #539
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #539 +/- ##
==========================================
- Coverage 83.99% 81.50% -2.49%
==========================================
Files 42 44 +2
Lines 1318 1633 +315
==========================================
+ Hits 1107 1331 +224
- Misses 211 302 +91
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This PR builds on top of #538 and further refines the detection and sequencing logic by making pose handling explicit and by tightening payload validation and sequence attribution.
What’s new in this PR
Detection model and API changes
Dropped
Detection.azimuthMade
pose_idmandatory for all detectionsCreation logic now:
others_bboxesSequencing logic improvements
Sequences are now looked up using:
camera_idpose_idlast_seenFor each new detection:
Its bbox is parsed
A candidate sequence is reused only if the last bbox overlaps
Otherwise, a new sequence is created
This prevents merging detections that are spatially distant but temporally close
Helpers refactor
Why this matters
The main goal of this change is to separate unrelated detections coming from the same image.
When a single frame contains both a real fire and a false positive, these detections have nothing in common spatially or semantically and must not end up in the same sequence.
By enforcing one detection per bbox and reusing sequences only when spatial overlap exists, we ensure that fires and false positives evolve independently, even if they originate from the same image and timestamp