-
Notifications
You must be signed in to change notification settings - Fork 0
Alert samples #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alert samples #24
Conversation
containers/notebooks/app/Download_Sequences_from_a_DistantAlertAPI.ipynb
Outdated
Show resolved
Hide resolved
Hi @fe51 , alerts got shifted bbox :) |
|
|
Hi ok my bad you are right for both 😄 |
MateoLostanlen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @fe51, thanks for the PR. Overall it works fine, nothing to say about that, but it’s a bit of a pity that it remains very manual:
There are quite a lot of steps if we want to select a new alert. Ideally, the cam_triangulation dictionary would be handled automatically, or only based on indexes
In any case, this notebook also needs some cleaning at the beginning. We can merge the PR to validate the new features, and then make another one later for the cleanup
|
Thanks for the feedback and I share your point of view, especially about triangulation alerts and the need to clean the notebook. About triangulation and automation, not implemented due to lack of time, as it is necessary to ensure that the correct cameras are associated with the selected alerts. I will open 2 issues to work on it. |


This PR introduces following modifications:
After this, might be useful to discuss and remove/refactor send_real_alerts.ipynb