Skip to content

Conversation

@fe51
Copy link
Member

@fe51 fe51 commented Oct 2, 2025

This PR introduces following modifications:

  • Updates Dockerfile to python 13
  • Updates Download notebook
  • Adds function in utils
  • Updates send_real_alerts with various example

After this, might be useful to discuss and remove/refactor send_real_alerts.ipynb

@fe51 fe51 requested a review from MateoLostanlen October 2, 2025 18:17
@fe51 fe51 requested a review from MateoLostanlen October 3, 2025 06:37
@fe51 fe51 requested a review from MateoLostanlen October 3, 2025 10:02
@MateoLostanlen
Copy link
Member

MateoLostanlen commented Oct 3, 2025

Screenshot 2025-10-03 at 13 36 00

Hi @fe51 , alerts got shifted bbox :)

@MateoLostanlen
Copy link
Member

I tired to run send_real_alerts.ipynb but got

Screenshot 2025-10-03 at 13 40 11

@fe51
Copy link
Member Author

fe51 commented Oct 3, 2025

Hi @MateoLostanlen

  • About shifted bbox, are you sur it does not come from the current bug in the platform ? (on big screen Bbox & image do not fit on large screens pyro-platform#181)

  • Have you delete the previous alert_samples dir you have ? (because alerts folder name because the name is related to the datetime of the first detection) -> and the code only check the presence of alert_samples dir

@MateoLostanlen
Copy link
Member

Hi ok my bad you are right for both 😄

Copy link
Member

@MateoLostanlen MateoLostanlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @fe51, thanks for the PR. Overall it works fine, nothing to say about that, but it’s a bit of a pity that it remains very manual:
There are quite a lot of steps if we want to select a new alert. Ideally, the cam_triangulation dictionary would be handled automatically, or only based on indexes

In any case, this notebook also needs some cleaning at the beginning. We can merge the PR to validate the new features, and then make another one later for the cleanup

@fe51
Copy link
Member Author

fe51 commented Oct 3, 2025

Thanks for the feedback and I share your point of view, especially about triangulation alerts and the need to clean the notebook.

About triangulation and automation, not implemented due to lack of time, as it is necessary to ensure that the correct cameras are associated with the selected alerts.
However, in this regard, it is also necessary to consider how often new triangulated alerts should be added to this development environment.

I will open 2 issues to work on it.

@fe51 fe51 merged commit d2c3f16 into main Oct 3, 2025
1 check passed
@MateoLostanlen MateoLostanlen deleted the alert-samples branch December 19, 2025 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants