Move third-party library imports to specific tests #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move third-party (`pylibmc` and `MySQLdb`) imports to specific tests, rather than importing them in global scope. This makes it easier to test a subset of the package without having to install all the dependencies, which can be particularly problematic when wheels are not provided (e.g. on PyPy3.11 or CPython 3.14).
Member
|
Thanks! Do you need a new release with this change? |
Contributor
Author
|
Thanks. No release needed, it's something we've patched for a long time already — just noticed I could upstream a better change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move third-party (
pylibmcandMySQLdb) imports to specific tests, rather than importing them in global scope. This makes it easier to test a subset of the package without having to install all the dependencies, which can be particularly problematic when wheels are not provided (e.g. on PyPy3.11 or CPython 3.14).This change is