Skip to content

Don't treat changemodel as a dictionary #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ambv merged 1 commit into from
Jan 23, 2025
Merged

Don't treat changemodel as a dictionary #575

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions master/custom/schedulers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ def __init__(self, *args, stable_builder_names, **kwargs):

@defer.inlineCallbacks
def addBuildsetForChanges(self, **kwargs):
log.msg("Preapring buildset for PR changes")
log.msg("Preparing buildset for PR changes")
changeids = kwargs.get("changeids")
if changeids is None or len(changeids) == 0:
log.msg("No changeids found")
Expand All @@ -22,10 +22,10 @@ def addBuildsetForChanges(self, **kwargs):
# requests being made in quick succession. All these changeids will
# have the same properties, so we can just pick the first one.
changeid = changeids[0]
chdict = yield self.master.db.changes.getChange(changeid)
change = yield self.master.db.changes.getChange(changeid)

builder_filter = chdict["properties"].get("builderfilter", None)
event = chdict["properties"].get("event", None)
builder_filter = change.properties.get("builderfilter", None)
event = change.properties.get("event", None)
if event:
# looks like `("issue_comment", "Change")` for a comment
event, _ = event
Expand Down
Loading