Skip to content

Add cache configuration #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zware merged 2 commits into from
Feb 20, 2025
Merged

Add cache configuration #577

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
21e3f9b
Add cache configuration
zware Feb 16, 2025
fedad4e
fixup! Add cache configuration
zware Feb 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions master/master.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,22 @@ c["configurators"] = [
)
]

# Note: these cache values are not currently tuned in any meaningful way.
# Some are taken straight from the buildbot docs at
# https://docs.buildbot.net/4.2.1/manual/configuration/global.html#caches
# and others are just guesses. For now, they're mostly meant to see if
# there's any appreciable impact on performance or memory usage.
c["caches"] = {
Copy link
Member

@vstinner vstinner Feb 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a comment explaining how you chose these numbers?

I'm fine with "These are mostly made up numbers just to see if there is any noticeable effect on either performance or memory usage."

"Changes": 100,
"Builds": 500,
"chdicts": 100,
"BuildRequests": 100,
"SourceStamps": 200,
"ssdicts": 200,
"objectids": 10,
"usdicts": 100,
}

# workers are set up in workers.py
c["workers"] = [w.bb_worker for w in WORKERS]

Expand Down