gh-142908: Don't use DK_IS_UNICODE in interpreter
#142909
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`DK_IS_UNICODE()` includes split keys and we don't want to specialize on those accesses..
kumaraditya303
approved these changes
Jan 8, 2026
reidenong
pushed a commit
to reidenong/cpython
that referenced
this pull request
Jan 12, 2026
…42909) `DK_IS_UNICODE()` includes split keys and we don't want to specialize on those accesses..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DK_IS_UNICODE()includes split keys and we don't want to specialize on those accesses..DK_IS_UNICODEwhere it should usedk_kind == DICT_KEYS_UNICODE#142908