gh-143995: Eliminate redundant refcounting in the JIT from LOAD_ATTR_MODULE #143996
+1,163
−1,023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aisk
requested review from
Fidget-Spinner,
ericsnowcurrently,
markshannon,
savannahostrowski and
tomasr8
as code owners
Member
|
I'm worried about the maintainability of Since we can now emit multiple uops in the optimizer, instead of adding parameters to @Fidget-Spinner can we take a bit more care to keep the code simple. It makes maintenance easier and will ultimately lead to better performance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated `uops` before:
Generated `uops` after:
Diff:
The time cost for 1000000 iterations in the
testfuncin the test case is reduced from approximately 126 seconds to 120 seconds.LOAD_ATTR_MODULE#143995