Skip to content

changing the setting_to_be_engine_invariant from tuple to set #3984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
apbose wants to merge 1 commit into
base: main
Choose a base branch
from
Open

changing the setting_to_be_engine_invariant from tuple to set #3984

apbose wants to merge 1 commit into from
+4 −3

Conversation

@apbose
Copy link
Collaborator

@apbose apbose commented Dec 31, 2025

No description provided.

@apbose apbose requested a review from zewenli98 December 31, 2025 19:20
@meta-cla meta-cla bot added the cla signed label Dec 31, 2025
@github-actions github-actions bot added component: core Issues re: The core compiler component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Dec 31, 2025
@github-actions github-actions bot requested a review from cehongwang December 31, 2025 19:21
zewenli98
zewenli98 approved these changes Dec 31, 2025
View reviewed changes
Copy link
Collaborator

@zewenli98 zewenli98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zewenli98 zewenli98 zewenli98 approved these changes

@cehongwang cehongwang Awaiting requested review from cehongwang

Assignees

No one assigned

Labels

cla signed component: api [Python] Issues re: Python API component: core Issues re: The core compiler component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@apbose @zewenli98