refactor constant char* to string_view #1216
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Best practice is to prefer `constexpr std::string_view` over `constexpr char*`. In principle, `string_view`s are more efficient to convert to `std::string` because they include their size in the object and can use a more efficient `string` constructor. Our benchmark shows the change to be performance neutral, but I still think it's a code improvement. Reviewed By: divyanshk Differential Revision: D90590675
scotts
force-pushed
the
export-D90590675
branch
from
3bbc6cd to
34331b9
Compare
|
This pull request has been merged in 1d8bcc5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Best practice is to prefer
constexpr std::string_viewoverconstexpr char*. In principle,string_views are more efficient to convert tostd::stringbecause they include their size in the object and can use a more efficientstringconstructor. Our benchmark shows the change to be performance neutral, but I still think it's a code improvement.Differential Revision: D90590675