-
Notifications
You must be signed in to change notification settings - Fork 200
Change CHANGLOG.md #427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change CHANGLOG.md #427
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -106,18 +106,21 @@ func (f *Flow) Start() { | |||||
| hasMore, workInfo, err := f.WorkProvider.Provide() | ||||||
| log.DebugF("work producer get work, hasMore:%v, workInfo: %+v, err: %+v", hasMore, workInfo, err) | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The logging here still uses the full workInfoData := ""
if workInfo != nil {
workInfoData = workInfo.Data
}
log.DebugF("work producer get work, hasMore:%v, workInfo: %s, err: %+v", hasMore, workInfoData, err)This prevents verbose logging when |
||||||
| if err != nil { | ||||||
| workInfoData := "" | ||||||
| if workInfo != nil { | ||||||
| workInfoData = workInfo.Data | ||||||
| } | ||||||
| if err.Code == data.ErrorCodeParamMissing || | ||||||
| err.Code == data.ErrorCodeLineHeader { | ||||||
| log.DebugF("work producer get work, skip:%s because:%s", workInfo, err) | ||||||
| log.DebugF("work producer get work, skip:%s because:%s", workInfoData, err) | ||||||
| f.notifyWorkSkip(workInfo, nil, err) | ||||||
| } else { | ||||||
| // 没有读到任何数据 | ||||||
| if workInfo == nil || len(workInfo.Data) == 0 { | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since
Suggested change
This maintains consistency and avoids redundant field access. |
||||||
| log.ErrorF("work producer get work fail: %s", err) | ||||||
| break | ||||||
| } | ||||||
|
|
||||||
| log.DebugF("work producer get work fail, error:%s info:%s", err, workInfo) | ||||||
| log.DebugF("work producer get work fail, error:%s info:%s", err, workInfoData) | ||||||
| f.notifyWorkFail(workInfo, err) | ||||||
| } | ||||||
| continue | ||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
“listbucket2 接口优化” 这个描述过于模糊,建议提供更多细节来说明具体的优化点。例如,是提升了性能、减少了内存占用,还是改变了接口行为?清晰的变更日志能帮助用户更好地理解每个版本的更新内容。