Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,13 @@
# 2.17.0
## 新增
1. 支持智能分层
2. get file 支持签名

## 优化
1. 下载对 CDN 友好,访问使 CDN 触发缓存
2. 下载废弃 --public,改为内部判定
3. listbucket2 接口优化

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

“listbucket2 接口优化” 这个描述过于模糊,建议提供更多细节来说明具体的优化点。例如,是提升了性能、减少了内存占用,还是改变了接口行为?清晰的变更日志能帮助用户更好地理解每个版本的更新内容。


# 2.16.1
## 修复
1. 修复 fput 指定域名不生效问题
Expand Down
9 changes: 6 additions & 3 deletions iqshell/common/flow/flow.go
Original file line number Diff line number Diff line change
Expand Up @@ -106,18 +106,21 @@ func (f *Flow) Start() {
hasMore, workInfo, err := f.WorkProvider.Provide()
log.DebugF("work producer get work, hasMore:%v, workInfo: %+v, err: %+v", hasMore, workInfo, err)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logging here still uses the full workInfo struct with %+v. This should also be changed to use workInfoData for consistency with the error handling below. Consider extracting workInfoData before this line and using it throughout:

workInfoData := ""
if workInfo != nil {
    workInfoData = workInfo.Data
}
log.DebugF("work producer get work, hasMore:%v, workInfo: %s, err: %+v", hasMore, workInfoData, err)

This prevents verbose logging when workInfo contains complex struct data.

if err != nil {
workInfoData := ""
if workInfo != nil {
workInfoData = workInfo.Data
}
if err.Code == data.ErrorCodeParamMissing ||
err.Code == data.ErrorCodeLineHeader {
log.DebugF("work producer get work, skip:%s because:%s", workInfo, err)
log.DebugF("work producer get work, skip:%s because:%s", workInfoData, err)
f.notifyWorkSkip(workInfo, nil, err)
} else {
// 没有读到任何数据
if workInfo == nil || len(workInfo.Data) == 0 {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since workInfoData is already extracted above (lines 109-112), use it here instead of accessing workInfo.Data directly:

Suggested change
if workInfo == nil || len(workInfo.Data) == 0 {
if workInfo == nil || len(workInfoData) == 0 {

This maintains consistency and avoids redundant field access.

log.ErrorF("work producer get work fail: %s", err)
break
}

log.DebugF("work producer get work fail, error:%s info:%s", err, workInfo)
log.DebugF("work producer get work fail, error:%s info:%s", err, workInfoData)
f.notifyWorkFail(workInfo, err)
}
continue
Expand Down