-
Notifications
You must be signed in to change notification settings - Fork 92
Adding new script RemoveDeadNoteLink #269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
removedeadnotelink/info.json
Outdated
| "platforms": ["linux", "macos", "windows"], | ||
| "version": "0.0.2", | ||
| "minAppVersion": "25.6.1", | ||
| "description": "This script creates a menu item and a button that search in all notes and remove links to note (MD file) no longer existing (aka dead note-link)." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By the description (that has a lot of grammar errors in my opinion 😅) I'm not sure if dead links in all notes are removed or just the current note.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
English is not my native language, I am sorry for the poor grammar. I will try to improve it (and/or use a free grammar checker).
But regarding your question I've wrote "in all notes"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about:
This script creates a menu item and a button that searches through all notes and removes links to all notes (Markdown files) that no longer exist, also known as dead note links.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed much clearer, thanks !!
Done
removedeadnotelink/info.json
Outdated
| "script": "removedeadnotelink.qml", | ||
| "authors": ["@Glin76"], | ||
| "platforms": ["linux", "macos", "windows"], | ||
| "version": "0.0.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't start with version 0.0.2 if it's the initial release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Hello,
I have tried to make the script as discussed in issue pbek/QOwnNotes#3291
It sure need testing but for "standard" links created by QownNotes it seems to work fine.
Let me know if some bugs need to be fixed