Work correctly on Ruby 3.5 #110
Merged
+6
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@searls This is still an issue with Ruby 4.0.0 preview2. Modulo 3.5/4.0 naming issues in the comments (which I can update), do you think it can be merged? |
Collaborator
|
slaps car roof you can fit so many maintainers in this gem. Since writing TLDR, I'm leaning on this lib less and less often. Want commit bit & gem push? |
Collaborator
Author
|
Sure, I'd be happy to help out with maintenance. |
Collaborator
Owner
|
Definitely not worth an org. Just added you @jeremyevans ! |
Collaborator
Author
|
Accepted. Thank you! |
On Ruby 4.0, method.source_location returns an array with 5 entries instead of 2. Additional entries are start column, end line, and end column. Don't assume start_line is the last entry in the array, always use offset 1. If the end line is available, use it instead of splitting the method source and trying to determine the number of lines in it. Do not require method_source on Ruby 4.0+, since it will not be used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Ruby 3.5, method.source_location returns an array with 5 entries instead of 2. Additional entries are start column, end line, and end column.
Don't assume start_line is the last entry in the array, always use offset 1.
If the end line is available, use it instead of splitting the method source and trying to determine the number of lines in it.