Work with Ruby 4.0.0-preview3, add minitest 6, drop minitest 4 #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was reverted in Ruby 4.0, with only about a week until the release. While only the require_relative line actually needed a change, since the code itself would be correct even with the revert, I think it's best to use simpler code. It's likely Ruby 4.1 will include support for this, so comment out the code to make it easy to change back.
Do not assume it is installed as `ruby`. Use `-S rake` to execute rake with the current Ruby version.
This file was removed in minitest 6, and there is no point in requiring it if it isn't used.
No lib changes are needed.
The same tests work for both minitest 5 and minitest 6. I'd like to rename test/examples/minitest_5_example_test.rb to test/examples/minitest_example_test.rb, but since that file already exists, I chose the ugly test/examples/minitest_5_or_6_example_test.rb
This uses require_relative to load test_helper, instead of requiring the test directory to be in the Ruby load path. This has test_helper use require_relative to load m, instead of requiring the lib directory to be in the Ruby load path.
Minitest gives better progress output by default, with `.` for each test, instead of using a spinner that does not provide information on progress.
This avoids the need for load path modification.
When testing, it's best to have all testing libraries installed. This doesn't work for minitest 4, but that is over 12 years old at this point, and we can safely drop support for it. This also removes the tests tasks from the Rakefile.
minitest 6 was just released, and minitest 5 was released over 12 years ago. It's unlikely there are any minitest 4 users that need updated versions of m. Remove BUNDLE_GEMFILE usage in test_bench.rb while here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby 4.0.0-preview3 reverted the change to have source_location return the end line. It's possible the revert will be reverted before the final Ruby 4.0.0 release, but this allows for easily switching back.
This adds support for minitest 6 and drops support for minitest 4. minitest 5 was released over 12 years, there's really no need to support minitest 4 any more.
This adds support for running individual tests (of
mitself) usingruby test/some_test.rb.With minitest 4 dropped, there is no reason to have separate gemfiles. This switches to a single gemfile that loads both test/unit and minitest.
This also fixes
musage in any environment whererubyis not the current Ruby program. This usesRbConfig.rubyto get the current Ruby program.See individual commits for more details.