Add Kochen-Specker inequality implementation #449
+949
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstrain115
reviewed
Dec 18, 2025
| virtual_z_half_turns: float = 0.0, | ||
| add_ancilla_to_measure_key: bool = False, | ||
| ) -> cirq.FrozenCircuit: | ||
| """Circuit to measure the idx'th col or row of this magic square. |
Collaborator
There was a problem hiding this comment.
idx is not a parameter to this function? I am not sure I understand this docstring.
| for idx in indices | ||
| } | ||
|
|
||
| def pauli_key(row: int, col: int, axis: Axis) -> PauliKey: |
Collaborator
There was a problem hiding this comment.
I recommend pulling this out instead of having it be an inline function (it's more testable that way).
| measure_key: str | None, | ||
| virtual_z_half_turns: float = 0.0, | ||
| ) -> cirq.FrozenCircuit: | ||
| """Make a circuit to perform a QND measurement of the specified Pauli. |
Collaborator
There was a problem hiding this comment.
What's a QND measurement? We should define this in the docstring or link to something.
|
|
||
| def measure_reset_circuit( | ||
| q0: cirq.Qid, q1: cirq.Qid, anc: cirq.Qid, measure_key: str | None | ||
| ) -> cirq.FrozenCircuit: |
| @@ -0,0 +1,889 @@ | |||
| # Copyright 2025 Google | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.