Fix group delimiter resolution for nested components in XSL template

[Copilot]

The XSL template for generating group constructors failed to resolve the delimiter when a group's first element was a nested component (component containing component). This produced invalid Java code:

// Generated before fix:
super(20001, , ORDER);  // Missing delimiter parameter

// Generated after fix:
super(20001, 58, ORDER);  // Correct field number from nested component

Changes

• MessageSubclass.xsl: Changed component template match pattern from group//component to component in group-delimeter mode. The restrictive pattern prevented recursion into component definitions resolved from the global components tree, as they were no longer descendants of a group node. The generalized pattern matches the existing patterns for field and group templates in the same mode.

• Test fixtures: Added minimal FIX spec (NestedComponentsTest.xml) and regression test (NestedComponentDelimiterTest.java) that exercises a three-level component hierarchy: NoEntries group → Level1 component → Level2 component → Text field(58). Test validates the generated constructor contains the correct delimiter from the deeply nested field.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• www.w3.org
  • Triggering command: `/opt/hostedtoolcache/CodeQL/2.23.7/x64/codeql/tools/linux64/java/bin/java /opt/hostedtoolcache/CodeQL/2.23.7/x64/codeql/tools/linux64/java/bin/java -jar /opt/hostedtoolcache/CodeQL/2.23.7/x64/codeql/xml/tools/xml-extractor.jar --fileList=/home/REDACTED/work/quickfixj/.codeql-scratch/dbs/java/working/files-to-index4785471679713898186.list --sourceArchiveDir=/home/REDACTED/work/quickfixj/.codeql-scratch/dbs/java/src --outputDir=/home/REDACTED/work/quickfixj/.codeql-scratch/dbs/java/trap/java ue

Co-authored-by: chrjohn <6644028+chrjohn@users.noreply.github.com>` (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Original prompt

Summary
Fix MessageSubclass.xsl so MessageCodeGenerator sets the group delimiter correctly when the first element of a group is a component whose first element is another component (nested > 1). Add a regression test using a minimal FIX spec to ensure the generated code uses the proper delimiter and compiles structurally.

Context

• Repository: quickfix-j/quickfixj
• Problem: Issue MessageCodeGenerator fails to set group delimiter for nested components #1084 reports generated code like:
  super(20001, , ORDER);
  when generating a group whose first child is a nested component-of-component. Current XSL uses a template match="group//component" in mode group-delimeter, which fails after the first recursion step (the next component node is resolved in the global /fix/components tree and no longer matches group//component). As a result, no delimiter is emitted.

Proposed changes

1. XSLT fix (MessageSubclass.xsl)

• Replace the component delimiter template that currently only matches descendants under a group:
  <xsl:template mode="group-delimeter" match="group//component"> ... </xsl:template>
  with a generalized version that matches any component node:
  <xsl:template mode="group-delimeter" match="component"> ... </xsl:template>
• Keep existing field and group templates unchanged. This allows recursion across arbitrarily deep nested components to reach the first field (or nested group) and output its tag number correctly.

2. Regression test (quickfixj-codegenerator)

• Add a minimal FIX specification XML under test resources that defines:
  • fields: Text(58), NoEntries(20001)
  • components: Level2 contains field Text; Level1 contains component Level2; NestedTwice contains a group NoEntries whose first element is component Level1
  • a dummy message that references the NestedTwice component so code-generation includes it
• Add a JUnit test that runs MessageCodeGenerator on this spec to generate component classes into a temp output directory and asserts that the generated NestedTwice.java group constructor contains:
  super(20001, 58, ORDER);
• Optionally assert that generated file contains the ORDER array skeleton and the NoEntries group class is present (structural compile checks are covered by string contains; we don’t require javac invocation here, consistent with existing tests in this module).

Files to modify/add

• Modify: quickfixj-codegenerator/src/main/resources/org/quickfixj/codegenerator/MessageSubclass.xsl
  • Replace the group-delimeter template for components with a version that matches any component
• Add: quickfixj-codegenerator/src/test/resources/org/quickfixj/codegenerator/NestedComponentsTest.xml
  • Minimal dictionary as described above
• Add: quickfixj-codegenerator/src/test/java/org/quickfixj/codegenerator/NestedComponentDelimiterTest.java
  • New JUnit test to generate classes from NestedComponentsTest.xml and assert on the generated NestedTwice.java constructor

Acceptance criteria

• Running the new test passes on Linux/macOS/Windows JDK 8+.
• When generating a component with a group starting with a nested component-of-component, the constructor is generated with the correct delimiter, e.g. super(20001, 58, ORDER).
• Existing behavior for groups whose first item is a field or a group is unchanged.

Notes

• The change is minimal and localized to the XSL template selection; it does not alter other generation templates or message/component field ordering logic.
• The test mirrors the user-reported scenario but with a self-contained spec so CI can validate future changes.

Linked issue

• Fixes MessageCodeGenerator fails to set group delimiter for nested components #1084

This pull request was created as a result of the following prompt from Copilot chat.

Summary
Fix MessageSubclass.xsl so MessageCodeGenerator sets the group delimiter correctly when the first element of a group is a component whose first element is another component (nested > 1). Add a regression test using a minimal FIX spec to ensure the generated code uses the proper delimiter and compiles structurally.

Context

• Repository: quickfix-j/quickfixj
• Problem: Issue MessageCodeGenerator fails to set group delimiter for nested components #1084 reports generated code like:
  super(20001, , ORDER);
  when generating a group whose first child is a nested component-of-component. Current XSL uses a template match="group//component" in mode group-delimeter, which fails after the first recursion step (the next component node is resolved in the global /fix/components tree and no longer matches group//component). As a result, no delimiter is emitted.

Proposed changes

1. XSLT fix (MessageSubclass.xsl)

• Replace the component delimiter template that currently only matches descendants under a group:
  <xsl:template mode="group-delimeter" match="group//component"> ... </xsl:template>
  with a generalized version that matches any component node:
  <xsl:template mode="group-delimeter" match="component"> ... </xsl:template>
• Keep existing field and group templates unchanged. This allows recursion across arbitrarily deep nested components to reach the first field (or nested group) and output its tag number correctly.

2. Regression test (quickfixj-codegenerator)

• Add a minimal FIX specification XML under test resources that defines:
  • fields: Text(58), NoEntries(20001)
  • components: Level2 contains field Text; Level1 contains component Level2; NestedTwice contains a group NoEntries whose first element is component Level1
  • a dummy message that references the NestedTwice component so code-generation includes it
• Add a JUnit test that runs MessageCodeGenerator on this spec to generate component classes into a temp output directory and asserts that the generated NestedTwice.java group constructor contains:
  super(20001, 58, ORDER);
• Optionally assert that generated file contains the ORDER array skeleton and the NoEntries group class is present (structural compile checks are covered by string contains; we don’t require javac invocation here, consistent with existing tests in this module).

Files to modify/add

• Modify: quickfixj-codegenerator/src/main/resources/org/quickfixj/codegenerator/MessageSubclass.xsl
  • Replace the group-delimeter template for components with a version that matches any component
• Add: quickfixj-codegenerator/src/test/resources/org/quickfixj/codegenerator/NestedComponentsTest.xml
  • Minimal dictionary as described above
• Add: quickfixj-codegenerator/src/test/java/org/quickfixj/codegenerator/NestedComponentDelimiterTest.java
  • New JUnit test to generate classes from NestedComponentsTest.xml and assert on the generated NestedTwice.java constructor

Acceptance criteria

• Running the new test passes on Linux/macOS/Windows JDK 8+.
• When generating a component with a group starting with a nested component-of-component, the constructor is generated with the correct delimiter, e.g. super(20001, 58, ORDER).
• Existing behavior for groups whose first item is a field or a group is unchanged.

Notes

• The change is minimal and localized to the XSL template selection; it does not alter other generation templates or message/component field ordering logic.
• The test mirrors the user-reported scenario but with a self-contained spec so CI can validate future changes.

Linked issue

• Fixes MessageCodeGenerator fails to set group delimiter for nested components #1084

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.