Skip to content

Conversation

@spietras
Copy link
Member

@spietras spietras commented Dec 5, 2025

No description provided.

@spietras spietras requested a review from Copilot December 5, 2025 22:47
@spietras spietras self-assigned this Dec 5, 2025
@spietras spietras added the feature New feature or request label Dec 5, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds comprehensive Python type checking infrastructure using Pyright across the repository. The changes fix type annotations for pytest fixtures that use yield and configure the development environment to support static type analysis.

  • Updated return type annotations from Path to Generator[Path] for all pytest fixtures that use yield
  • Added Pyright configuration files and integrated type checking into the development workflow
  • Configured VS Code, trunk, and devcontainer settings to enable Pyright analysis

Reviewed changes

Copilot reviewed 62 out of 67 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/service/test_test.py Added Generator import and corrected fixture return type annotation
tests/service/test_lint.py Added Generator import and corrected fixture return type annotation
tests/package/test_test.py Added Generator import and corrected fixture return type annotation
tests/package/test_lint.py Added Generator import and corrected fixture return type annotation
tests/generic/test_test.py Added Generator import and corrected fixture return type annotation
tests/generic/test_lint.py Added Generator import and corrected fixture return type annotation
tests/database/test_test.py Added Generator import and corrected fixture return type annotation
tests/database/test_lint.py Added Generator import and corrected fixture return type annotation
tests/conftest.py Added Generator import and corrected fixture return type annotation
tests/app/test_test.py Added Generator import and corrected fixture return type annotation
tests/app/test_lint.py Added Generator import and corrected fixture return type annotation
src/service/tests/test_lint.py Added Generator import and corrected fixture return type annotation
src/service/tests/test_docs.py Added Generator import and corrected fixture return type annotation
src/service/tests/conftest.py Added Generator import and corrected fixture return type annotation
src/service/pyproject.toml Created Pyright configuration for Python 3.13 type checking
src/service/flake.nix Added pytest to PATH for Pyright and set PYRIGHT_PYTHON environment variable
src/package/tests/test_lint.py Added Generator import and corrected fixture return type annotation
src/package/tests/test_docs.py Added Generator import and corrected fixture return type annotation
src/package/tests/conftest.py Added Generator import and corrected fixture return type annotation
src/package/pyproject.toml Created Pyright configuration for Python 3.13 type checking
src/package/flake.nix Added pytest to PATH for Pyright and set PYRIGHT_PYTHON environment variable
src/generic/tests/test_lint.py Added Generator import and corrected fixture return type annotation
src/generic/tests/test_docs.py Added Generator import and corrected fixture return type annotation
src/generic/tests/conftest.py Added Generator import and corrected fixture return type annotation
src/generic/pyproject.toml Created Pyright configuration for Python 3.13 type checking
src/generic/flake.nix Added pytest to PATH for Pyright and set PYRIGHT_PYTHON environment variable
src/database/tests/test_lint.py Added Generator import and corrected fixture return type annotation
src/database/tests/test_docs.py Added Generator import and corrected fixture return type annotation
src/database/tests/conftest.py Added Generator import and corrected fixture return type annotation
src/database/pyproject.toml Created Pyright configuration for Python 3.13 type checking
src/database/flake.nix Added pytest to PATH for Pyright and set PYRIGHT_PYTHON environment variable
src/app/tests/test_lint.py Added Generator import and corrected fixture return type annotation
src/app/tests/test_docs.py Added Generator import and corrected fixture return type annotation
src/app/tests/conftest.py Added Generator import and corrected fixture return type annotation
src/app/pyproject.toml Created Pyright configuration for Python 3.13 type checking
src/app/flake.nix Added pytest to PATH for Pyright and set PYRIGHT_PYTHON environment variable
pyproject.toml Created root-level Pyright configuration for Python 3.13 type checking
flake.nix Added pytest to PATH for Pyright and set PYRIGHT_PYTHON environment variable
.vscode/settings.json Enabled Pyright diagnostics and pytest testing in VS Code
.trunk/trunk.yaml Enabled pyright@1.1.407 linter with custom Python PATH configuration
.trunk/configs/ruff.toml Disabled strict type-related rules that conflict with gradual typing adoption
.devcontainer/devcontainer.json Configured Python analysis to use auto node executable detection
Files not reviewed (5)
  • src/app/src/{{ '{% if docs %}docs{% endif %}' }}/package-lock.json: Language not supported
  • src/database/src/{{ '{% if docs %}docs{% endif %}' }}/package-lock.json: Language not supported
  • src/generic/src/{{ '{% if docs %}docs{% endif %}' }}/package-lock.json: Language not supported
  • src/package/src/{{ '{% if docs %}docs{% endif %}' }}/package-lock.json: Language not supported
  • src/service/src/{{ '{% if docs %}docs{% endif %}' }}/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@spietras spietras merged commit ed9f98e into main Dec 5, 2025
8 checks passed
@spietras spietras deleted the pyright branch December 5, 2025 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants