-
Notifications
You must be signed in to change notification settings - Fork 0
Added Python type checking #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds comprehensive Python type checking infrastructure using Pyright across the repository. The changes fix type annotations for pytest fixtures that use yield and configure the development environment to support static type analysis.
- Updated return type annotations from
PathtoGenerator[Path]for all pytest fixtures that useyield - Added Pyright configuration files and integrated type checking into the development workflow
- Configured VS Code, trunk, and devcontainer settings to enable Pyright analysis
Reviewed changes
Copilot reviewed 62 out of 67 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/service/test_test.py | Added Generator import and corrected fixture return type annotation |
| tests/service/test_lint.py | Added Generator import and corrected fixture return type annotation |
| tests/package/test_test.py | Added Generator import and corrected fixture return type annotation |
| tests/package/test_lint.py | Added Generator import and corrected fixture return type annotation |
| tests/generic/test_test.py | Added Generator import and corrected fixture return type annotation |
| tests/generic/test_lint.py | Added Generator import and corrected fixture return type annotation |
| tests/database/test_test.py | Added Generator import and corrected fixture return type annotation |
| tests/database/test_lint.py | Added Generator import and corrected fixture return type annotation |
| tests/conftest.py | Added Generator import and corrected fixture return type annotation |
| tests/app/test_test.py | Added Generator import and corrected fixture return type annotation |
| tests/app/test_lint.py | Added Generator import and corrected fixture return type annotation |
| src/service/tests/test_lint.py | Added Generator import and corrected fixture return type annotation |
| src/service/tests/test_docs.py | Added Generator import and corrected fixture return type annotation |
| src/service/tests/conftest.py | Added Generator import and corrected fixture return type annotation |
| src/service/pyproject.toml | Created Pyright configuration for Python 3.13 type checking |
| src/service/flake.nix | Added pytest to PATH for Pyright and set PYRIGHT_PYTHON environment variable |
| src/package/tests/test_lint.py | Added Generator import and corrected fixture return type annotation |
| src/package/tests/test_docs.py | Added Generator import and corrected fixture return type annotation |
| src/package/tests/conftest.py | Added Generator import and corrected fixture return type annotation |
| src/package/pyproject.toml | Created Pyright configuration for Python 3.13 type checking |
| src/package/flake.nix | Added pytest to PATH for Pyright and set PYRIGHT_PYTHON environment variable |
| src/generic/tests/test_lint.py | Added Generator import and corrected fixture return type annotation |
| src/generic/tests/test_docs.py | Added Generator import and corrected fixture return type annotation |
| src/generic/tests/conftest.py | Added Generator import and corrected fixture return type annotation |
| src/generic/pyproject.toml | Created Pyright configuration for Python 3.13 type checking |
| src/generic/flake.nix | Added pytest to PATH for Pyright and set PYRIGHT_PYTHON environment variable |
| src/database/tests/test_lint.py | Added Generator import and corrected fixture return type annotation |
| src/database/tests/test_docs.py | Added Generator import and corrected fixture return type annotation |
| src/database/tests/conftest.py | Added Generator import and corrected fixture return type annotation |
| src/database/pyproject.toml | Created Pyright configuration for Python 3.13 type checking |
| src/database/flake.nix | Added pytest to PATH for Pyright and set PYRIGHT_PYTHON environment variable |
| src/app/tests/test_lint.py | Added Generator import and corrected fixture return type annotation |
| src/app/tests/test_docs.py | Added Generator import and corrected fixture return type annotation |
| src/app/tests/conftest.py | Added Generator import and corrected fixture return type annotation |
| src/app/pyproject.toml | Created Pyright configuration for Python 3.13 type checking |
| src/app/flake.nix | Added pytest to PATH for Pyright and set PYRIGHT_PYTHON environment variable |
| pyproject.toml | Created root-level Pyright configuration for Python 3.13 type checking |
| flake.nix | Added pytest to PATH for Pyright and set PYRIGHT_PYTHON environment variable |
| .vscode/settings.json | Enabled Pyright diagnostics and pytest testing in VS Code |
| .trunk/trunk.yaml | Enabled pyright@1.1.407 linter with custom Python PATH configuration |
| .trunk/configs/ruff.toml | Disabled strict type-related rules that conflict with gradual typing adoption |
| .devcontainer/devcontainer.json | Configured Python analysis to use auto node executable detection |
Files not reviewed (5)
- src/app/src/{{ '{% if docs %}docs{% endif %}' }}/package-lock.json: Language not supported
- src/database/src/{{ '{% if docs %}docs{% endif %}' }}/package-lock.json: Language not supported
- src/generic/src/{{ '{% if docs %}docs{% endif %}' }}/package-lock.json: Language not supported
- src/package/src/{{ '{% if docs %}docs{% endif %}' }}/package-lock.json: Language not supported
- src/service/src/{{ '{% if docs %}docs{% endif %}' }}/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.