Extract ValidationError error message from pydantic and format it nicely #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As per this comment](#107 (comment)) I saw that the errors were not always being handled gracefully in notebooks.
These changes lead to simple error messages such as:
As you can see from the change in src/pyetm/models/scenarios.py, because the errors are already well formed, plural classes (e.g. Scenarios) need only surface the errors when calling underlying singular class methods (e.g. Scenario.load()). That probably requires further examination/testing to see which cases might be rending error messages twice.