Skip to content

Conversation

@kendonB
Copy link
Contributor

@kendonB kendonB commented Nov 27, 2025

Summary

  • preserve empty geometries when st_cast splits multiparts into multiple rows
  • rebuild output in original order and keep ids so attributes repeat correctly

Testing

  • devtools::load_all('.')
  • ran user repro (MULTIPOLYGON with empty) -> returns 5 rows with correct names/bboxes

@kendonB
Copy link
Contributor Author

kendonB commented Nov 27, 2025

FYI this was all gpt-5.1-codex-max-xhigh (including the PR)

@edzer
Copy link
Member

edzer commented Dec 13, 2025

That's a lot of code. Could you provide a very small example of what this code tries to solve?

@rsbivand
Copy link
Member

rsbivand commented Dec 13, 2025

Testing should also include full reverse dependency checks of all reverse depencencies, with comparative timings and memory profiling.

@kendonB
Copy link
Contributor Author

kendonB commented Dec 13, 2025

Sorry I missed the reference to the issue which contains the small example of what this code tries to solve #2555

@kendonB
Copy link
Contributor Author

kendonB commented Dec 13, 2025

Testing should also include full reverse dependency checks of all reverse depencencies, with comparative timings and memory profiling.

Running this now with r-lib/revdepcheck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants