fix: Improve BMC login logic #1596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code was recently extended to be able to fetch the session from either a Location HTTP header or from the json response. Unfortunately Dell sends both, which confused it.
stevekeay
force-pushed
the
fix-error-message-location-header
branch
from
4248957 to
7383e9e
Compare
| token = r.headers["X-Auth-Token"] | ||
| if "Location" in r.headers: | ||
| location = r.headers["Location"].split(self.ip_address)[1] | ||
| data = r.json() |
Contributor
There was a problem hiding this comment.
What will happen if JSON parsing fails?
Shouldn’t we use a try - catch block here?
Contributor
Author
There was a problem hiding this comment.
If the BMC response is invalid JSON then an Exception will be raised, causing the workflow to fail. While the resulting error won't be especially user-friendly, I think the behaviour is broadly correct. If we are looking to move the needle on "user friendly" for an argo workflow, this is probably not the low-hanging fruit :)
abhimanyu003
approved these changes
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code was recently extended to be able to fetch the session from either a Location HTTP header or from the json response. Unfortunately Dell sends both, which confused it.