-
Notifications
You must be signed in to change notification settings - Fork 3
Features/blog details jisan #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| return ( | ||
| <div className="max-w-5xl mx-auto bg-white shadow-md rounded-lg p-6"> | ||
| <h2 className="text-2xl font-semibold mb-6"> | ||
| Total Comment ({comments.length.toString().padStart(2, "0")}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use like this convertNumToPad(size(comments) || 0) helper function from appHelper.
Please do import size from lodash
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i tried this way but it's not working Total Comment ({convertNumToPad(comments.length)})
src/components/BlogDetails/BlogDetailsComponents/BlogComment.jsx
Outdated
Show resolved
Hide resolved
src/components/BlogDetails/BlogDetailsComponents/BlogComment.jsx
Outdated
Show resolved
Hide resolved
src/components/BlogDetails/BlogDetailsComponents/SearchAndCategories.jsx
Outdated
Show resolved
Hide resolved
src/components/BlogDetails/BlogDetailsComponents/SearchAndCategories.jsx
Outdated
Show resolved
Hide resolved
| import BlogHeader from "./BlogDetailsComponents/BlogHeader"; | ||
| import BlogComment from "./BlogDetailsComponents/BlogComment"; | ||
| import BlogCommentForm from "./BlogDetailsComponents/BlogCommentForm"; | ||
| import BlogSidebar from "./BlogDetailsComponents/BlogSidebar"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use absolute import from now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but it's not working
rahat2020
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please try to solve the feedback asap.
…eatures/blog_details_jisan
| import SearchAndCategories from "./SearchAndCategories"; | ||
| import RecentPost from "./RecentPost"; | ||
| import PostTags from "./PostTags"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import like this: '@/components/BlogDetails/BlogSidebar'
| placeholder="Search..." | ||
| className="w-full px-4 py-2 border rounded-lg focus:outline-none focus:ring-2 focus:ring-blue-400" | ||
| /> | ||
| <button |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please try to fix it otherwise let me know, and we will discuss it.
…racture and make code readable, clean, reuseable
all component and section are okay. but there is code optimize, dynamic all data, destracture are not ok.