[feat] Disable Rancher k8s version management for CAPI imported Clusters #2011
+21
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR disables the Rancher driven k8s version management for CAPI imported Clusters.
This is needed to not confuse users with an upgrade process that's not relevant and does not apply to their CAPI Clusters.
As for other Cluster import features, this requires a re-import of the Cluster. It will only apply to newly imported Clusters.
There's no reconcile logic for updates.
There is also no official documentation for this annotation.
For reference just read through the source code following the same named global Setting: https://github.com/rancher/rancher/blob/v2.13.1/pkg/settings/setting.go#L404
Fixes rancher/rancher#50776
For the end user, the UI should now look like this:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist: