-
Notifications
You must be signed in to change notification settings - Fork 13
[4.x] Added empty cart state + test #1091
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Roene-JustBetter
wants to merge
6
commits into
4.x
Choose a base branch
from
feature/empty-cart
base: 4.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
4c85743
Added empty cart state + test
Roene-JustBetter cbb2214
Apply fixes from Prettier
Roene-JustBetter 7317e38
Fix double space
Roene-JustBetter 0a475f7
Merge branch 'feature/empty-cart' of github.com:rapidez/core into fea…
Roene-JustBetter fea52a6
[CI] Update Snapshots
Roene-JustBetter dc86b88
Added translation
Roene-JustBetter File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| <div class="bg rounded-md mt-6 p-10 mb-6"> | ||
| <x-rapidez-empty-cart class="w-full flex items-center justify-center h-36" /> | ||
| </div> | ||
| <div class="flex flex-col items-center justify-center text-center text-secondary mb-10 text-2xl"> | ||
| @lang('You don\'t have anything in your cart.') | ||
| <div class="flex flex-wrap gap-3 mt-3"> | ||
| <x-rapidez::button.secondary v-if="!$root.loggedIn" href="{{ route('account.login') }}"> | ||
| @lang('Login to view your shopping cart') | ||
| </x-rapidez::button.secondary> | ||
| <x-rapidez::button.outline href="{{ url('/') }}"> | ||
| @lang('Continue shopping') | ||
| </x-rapidez::button.outline> | ||
| </div> | ||
| </div> | ||
|
|
||
| @include('rapidez::listing.partials.popular-products') |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletions
3
tests/playwright/cart.spec.js-snapshots/empty-cart-1-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions
3
tests/playwright/cart.spec.js-snapshots/empty-cart-1-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions
3
tests/playwright/cart.spec.js-snapshots/empty-cart-1-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions
3
tests/playwright/cart.spec.js-snapshots/empty-cart-1-firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions
3
tests/playwright/cart.spec.js-snapshots/empty-cart-1-webkit-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The regular cart icon has a different design

Is that a problem?