[4.x] Fix isNumeric #1137
Open
[4.x] Fix isNumeric #1137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Please rebase, most likely we don't have any screenshots changes anymore so we can merge |
Member
|
See: #1138 (review) |
Jade-GG
force-pushed
the
Jade-GG-patch-1
branch
from
5f4e6c6 to
43c817f
Compare
Jade-GG
force-pushed
the
Jade-GG-patch-1
branch
from
a8191b3 to
3577e08
Compare
Jade-GG
force-pushed
the
Jade-GG-patch-1
branch
from
0c6fa2d to
4844a01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was possible to have a
selectfield as a super attribute, which then would assume that it's a numeric field. However, these shouldn't be counted as numeric.Because the specific check was getting pretty long, I moved it to a function. We could also turn this into a property on the attribute itself, however because of the 5.x flat table migration I figured it would be too much trouble to do that cleanly in the query right now.