use permessage-deflate #113
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cboden Could you please take a look at this PR? It'd be useful for the client to support deflated messages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this deflated messages sent by server cannot be handled and the connection closes with exception Ratchet detected an invalid reserve code (thrown by ratchet/rfc6455/src/Messaging/MessageBuffer.php::270)
To improve on this I think that there needs to exist some nicer way of telling the Connector to send Sec-WebSocket-Extensions with permessage deflate options. For now I enable it by passing custom headers, but maybe a custom ClientNegotiator can be injected to the Connector?