Keep alive support #140
Open
Keep alive support #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would be amazing to get this support out. I suspect I have such a case where sometimes the connection is just gone and I am stuck listening forever. |
… connection if it does not receive a reply in time.
boenrobot
force-pushed
the
keep-alive-support
branch
from
bf3f2b0 to
8ff3491
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ability to set up a keep alive interval that will close the connection if it does not receive a reply in time.
I've modeled the code largely after the one found in the ratchet server, except it's only monitoring the one connection the client is connected to, and the timer is returned, so that it can potentially be canceled later (or be replaced).
Help with adding tests will be appreciated, as I can't find any test that exchange messages over a real connection - just mock connections or mock connection creation.
EDIT: Commit updated to use my github email... Because I committed this from work, it originally used my work email. Oops.