Update Socket component to support v0.5 through upcoming v1.0 #485
Conversation
composer.json
Outdated
| , "require": { | ||
| "php": ">=5.3.9" | ||
| , "react/socket": "^0.3 || ^0.4" | ||
| , "react/socket": "dev-master as 0.5" |
There was a problem hiding this comment.
This should be ^0.5 once the release is out.
clue
changed the title
|
Updated and rebased now that the Socket v0.5.0 release is out |
|
The good news: I've merged this into the 0.4 branch The bad news: As |
|
I understand that it may be safer to bump the major version here, but I still think my argument holds that this is actually not a BC break at all, see reactphp/http#90 (comment) (and following) for more details. I'll leave this up to you 👍 Is there anything I can do to help this PR progress? Technically, it's possible to support the new Socket API as well as the old Socket API at the same time by using duck-typing and/or reflection. Would you be interested in this here? |
|
Any chance to get this going? Currently its impossible to use php-pm together with ratchet :( |
|
See my comment above, I still think my arguments holds that this is actually not a BC break at all and I'm open to support both Socket versions if there's demand 👍 @andig What do you suggest here? Is this really something that ought to be fixed in Ratchet? If so, how? |
My proposal/wish would be for a ratchet release supporting socket 0.5. For our application based on A first 0.4 release of ratchet should be suitable to address any type of BC break?, potentially movong other breaking changes to 0.5 then? |
|
Updated to fix event arguments and explicitly pass required arguments, see also reactphp/stream#69 for rationale. This failing tests on Travis are unrelated, it looks like PHP 5.6 and PHP 7 picks an incompatible PHPUnit version. |
|
ping @cboden is there any chance to get 0.4 rolling- if thats the way to go- with socket 0.5 support? Working on http://volkszaehler.org which uses both ratchet and react/http (ancient commit unfortunately due to backed out code) I'd highly appreciate if all libraries were installable again with socket 0.5 as least common denominator. |
|
@cboden bump :) seeing socket 0.5 support merged will be great. |
Socket v0.7 and v0.6 contain some major changes, but this does not affect usage within Ratchet, so it's actually compatible with all latest releases.
|
I've updated this PR to include support for Socket v0.7 and v0.6 releases. Socket v0.7 and v0.6 contain some major changes, but this does not affect usage within Ratchet, so it's actually compatible with all latest releases.
@cboden What's the status on this PR? Will this be cherry-picked over to your release branch and/or will this PR ever be merged into the current release branch or do you plan to close this eventually? |
|
Because Ratchet's However, I've spent a bit of time recently, and just need a bit more time to finish documenting 0.4 then I can release it with this PR and #500 |
|
@cboden I still think that the above argument still holds that this does in fact not break Ratchet's API, but actually only the API of a dependency of Ratchet. This is also pointed out in the related discussion for react/http linked above (reactphp/http#90 (comment)). See also http://semver.org/#what-should-i-do-if-i-update-my-own-dependencies-without-changing-the-public-api Anyway, I agree that we can play "safe" here just in case and bump Ratchet to |
|
Is there anything I can do to help this PR progress? I'd like to move forward here and either get this in or close this, how can I help? |
Socket v0.8 only contains some minor breaking changes, which can be circumvented by ignoring URI schemes here. Future Socket v1.0 will not contain any BC breaks, so it's actually compatible with the last release.
|
I've just updated this to also support upcoming react/socket v1.0 and current v0.8 |
clue
changed the title
4 participants
Filing this as a WIP until the v0.5 release has actually been tagged and released.
Refs reactphp/http#90