Skip to content

Conversation

@rawcomposition
Copy link
Owner

Add ability to edit custom markers from within the marker modal.

@rawcomposition rawcomposition requested a review from Copilot June 25, 2025 22:33
@rawcomposition rawcomposition self-assigned this Jun 25, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds the ability to edit custom markers directly from the marker modal. Key changes include:

  • Renaming and updating marker input types (including renaming MarkerInput to MarkerUpdateInput and adding an "icon" field).
  • Updating the trip provider and modal configuration to support the new marker editing functionality.
  • Removing the old AddMarker and ViewMarker modals and replacing them with a unified Marker modal, along with backend support for marker updates.

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
shared/types.ts Renaming MarkerInput to MarkerUpdateInput and updating its fields.
frontend/providers/trip.tsx Adding/refactoring the trip context to include a refetch method.
frontend/providers/modals.tsx Adjusting modal imports and mapping to use the new Marker component.
frontend/pages/whats-new.tsx Updating release notes to announce marker edit capabilities.
frontend/modals/ViewMarker.tsx Removing the old view marker modal.
frontend/modals/Marker.tsx Creating the new unified marker modal for add/edit functionality.
frontend/modals/AddMarker.tsx Removing the old add marker modal.
frontend/components/Mapbox.tsx Updating marker click handling to pass markerId to the modal.
frontend/components/ItineraryDay.tsx Modifying modal calls to pass markerId instead of the full marker object.
backend/routes/trips/[tripId]/markers.ts Adding a PATCH endpoint to update marker details on the backend.
Comments suppressed due to low confidence (1)

shared/types.ts:205

  • Consider documenting the separation between MarkerUpdateInput and MarkerNotesInput since the optional 'notes' field was removed; this will clarify that note updates are handled separately.
export type MarkerUpdateInput = {

@rawcomposition rawcomposition merged commit 786207c into main Jun 25, 2025
2 checks passed
@rawcomposition rawcomposition deleted the edit-marker branch June 25, 2025 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants