Skip to content

Conversation

@kemar-christie
Copy link
Contributor

Description

Refine the device list and introduce a new device category (MacBook).

Screencast

iOS-Resolution.Macbook.Devices.Type.Addition.Demo.mp4

Checklist

- Added MacBook family to device types
- Included MacBook Air (M1-M4) and MacBook Pro (M1-M5) models
- Added MacBook filter option with monitor icon
- Updated extension description to include MacBook
- Added kemar.christie to contributors list
- Updated CHANGELOG with MacBook support entry
@raycastbot raycastbot added extension fix / improvement Label for PRs with extension's fix improvements extension: ios-resolution Issues related to the ios-resolution extension platform: macOS platform: Windows labels Jan 30, 2026
@raycastbot
Copy link
Collaborator

raycastbot commented Jan 30, 2026

Thank you for your contribution! 🎉

🔔 @ertembiyik you might want to have a look.

You can use this guide to learn how to check out the Pull Request locally in order to test it.

📋 Quick checkout commands
BRANCH="add-macbooks-as-devices-type"
FORK_URL="https://github.com/kemar-christie/raycast-extensions.git"
EXTENSION_NAME="ios-resolution"
REPO_NAME="raycast-extensions"

git clone -n --depth=1 --filter=tree:0 -b $BRANCH $FORK_URL
cd $REPO_NAME
git sparse-checkout set --no-cone "extensions/$EXTENSION_NAME"
git checkout
cd "extensions/$EXTENSION_NAME"
npm install && npm run dev

We're currently experiencing a high volume of incoming requests. As a result, the initial review may take up to 10-15 business days.

"scaleFactor": 2,
"screenDiagonal": "16.2\"",
"aspectRatio": "16:10",
"releaseDate": "2024-11-08"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the json update does not contain all the MacBooks released by Appple

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohh yes, i forgot to copy those on sorry about that.

Copy link
Contributor Author

@kemar-christie kemar-christie Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix along with all other changes in the next commit

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor

@ertembiyik ertembiyik Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i believe it still does not include all the macbooks released, also i'm confused about the naming a little bit for macbook-touch-bar for example, it should not be named like that, we should aim for release date naming

you can check naming + all the models at https://mactracker.ca, they have all the models listed there

image

and please don't resolve threads opened by me

Copy link
Contributor Author

@kemar-christie kemar-christie Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohhh that's the format you want for the Macbooks ok I will get that done today later on in the evening.

Also I close the ones open by you after I have resolved them. I need something to check off my progress. I don't want all of them to be open. Is it that you want to mark then as resolved yourself? You have other stuff doing so to wait on you to check them off wouldn't be feasible. All I have to do is ensure that I complete what is requested then mark them as resolved.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aight, it works both way: you mark threads completed and i mark threads verified

but no push here, thank you for your contribution, let's get the rest models + the right format and merge it!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great will be done by EOD. Never knew this tool existed. Maybe I can add other devices with screen👀😂.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 30, 2026

Greptile Overview

Greptile Summary

This PR adds MacBook as a new device family to the iOS Resolution extension, expanding it beyond just iOS devices. The implementation adds 17 MacBook models (Air and Pro variants from M1 through M5 chips) with their display specifications.

Key Changes:

  • Added MacBook to the device family type definition
  • Added MacBook filter option with monitor icon to the UI dropdown
  • Updated extension description to mention MacBook devices
  • Added 17 MacBook entries with resolution data to devices.json

Issues Found:

  • CHANGELOG entry is missing ## heading syntax (syntax error)
  • MacBook Air 13" M4 and 15" M4 have incorrect future release dates (2025-03-12) when they were actually released in 2024
  • MacBook Pro 14" M5 is included with a future release date (2025-10-22), but this model hasn't been announced or released yet

The code implementation is clean and follows existing patterns. The TypeScript types are properly updated, and the UI integration is consistent with other device families.

Confidence Score: 2/5

  • This PR has critical data accuracy issues with incorrect release dates and unreleased product
  • While the code implementation is solid, the device data contains factual errors (wrong M4 release dates) and includes an unreleased product (M5), which undermines the extension's reliability
  • extensions/ios-resolution/src/data/devices.json requires immediate attention to correct release dates and remove unreleased model

Important Files Changed

Filename Overview
extensions/ios-resolution/CHANGELOG.md Added MacBook device type entry with incorrect heading syntax (missing ##)
extensions/ios-resolution/src/data/devices.json Added 17 MacBook models with resolution data, but includes incorrect future release dates and unreleased M5 model

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, 4 comments

Edit Code Review Agent Settings | Greptile

…tting

- Added 10 legacy MacBook models to devices data
- Fixed CHANGELOG heading syntax
- Removed trailing periods from descriptions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

extension fix / improvement Label for PRs with extension's fix improvements extension: ios-resolution Issues related to the ios-resolution extension platform: macOS platform: Windows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants