-
Notifications
You must be signed in to change notification settings - Fork 5.3k
feat(ios-resolutions): Add MacBooks as Devices Type #25004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(ios-resolutions): Add MacBooks as Devices Type #25004
Conversation
- Added MacBook family to device types - Included MacBook Air (M1-M4) and MacBook Pro (M1-M5) models - Added MacBook filter option with monitor icon - Updated extension description to include MacBook - Added kemar.christie to contributors list - Updated CHANGELOG with MacBook support entry
|
Thank you for your contribution! 🎉 🔔 @ertembiyik you might want to have a look. You can use this guide to learn how to check out the Pull Request locally in order to test it. 📋 Quick checkout commandsBRANCH="add-macbooks-as-devices-type"
FORK_URL="https://github.com/kemar-christie/raycast-extensions.git"
EXTENSION_NAME="ios-resolution"
REPO_NAME="raycast-extensions"
git clone -n --depth=1 --filter=tree:0 -b $BRANCH $FORK_URL
cd $REPO_NAME
git sparse-checkout set --no-cone "extensions/$EXTENSION_NAME"
git checkout
cd "extensions/$EXTENSION_NAME"
npm install && npm run devWe're currently experiencing a high volume of incoming requests. As a result, the initial review may take up to 10-15 business days. |
| "scaleFactor": 2, | ||
| "screenDiagonal": "16.2\"", | ||
| "aspectRatio": "16:10", | ||
| "releaseDate": "2024-11-08" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the json update does not contain all the MacBooks released by Appple
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ohh yes, i forgot to copy those on sorry about that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will fix along with all other changes in the next commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i believe it still does not include all the macbooks released, also i'm confused about the naming a little bit for macbook-touch-bar for example, it should not be named like that, we should aim for release date naming
you can check naming + all the models at https://mactracker.ca, they have all the models listed there
and please don't resolve threads opened by me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohhh that's the format you want for the Macbooks ok I will get that done today later on in the evening.
Also I close the ones open by you after I have resolved them. I need something to check off my progress. I don't want all of them to be open. Is it that you want to mark then as resolved yourself? You have other stuff doing so to wait on you to check them off wouldn't be feasible. All I have to do is ensure that I complete what is requested then mark them as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aight, it works both way: you mark threads completed and i mark threads verified
but no push here, thank you for your contribution, let's get the rest models + the right format and merge it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great will be done by EOD. Never knew this tool existed. Maybe I can add other devices with screen👀😂.
Greptile OverviewGreptile SummaryThis PR adds MacBook as a new device family to the iOS Resolution extension, expanding it beyond just iOS devices. The implementation adds 17 MacBook models (Air and Pro variants from M1 through M5 chips) with their display specifications. Key Changes:
Issues Found:
The code implementation is clean and follows existing patterns. The TypeScript types are properly updated, and the UI integration is consistent with other device families. Confidence Score: 2/5
Important Files Changed
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 files reviewed, 4 comments
…tting - Added 10 legacy MacBook models to devices data - Fixed CHANGELOG heading syntax - Removed trailing periods from descriptions

Description
Refine the device list and introduce a new device category (MacBook).
Screencast
iOS-Resolution.Macbook.Devices.Type.Addition.Demo.mp4
Checklist
npm run buildand tested this distribution build in Raycastassetsfolder are used by the extension itselfREADMEare located outside the metadata folder if they were not generated with our metadata tool