-
Notifications
You must be signed in to change notification settings - Fork 5.3k
feat: add additional "open with" action to raycast-zoxide #25011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution! 🎉 🔔 @mrpunkin you might want to have a look. You can use this guide to learn how to check out the Pull Request locally in order to test it. 📋 Quick checkout commandsBRANCH="main"
FORK_URL="https://github.com/josiahwiebe/raycast-extensions.git"
EXTENSION_NAME="raycast-zoxide"
REPO_NAME="raycast-extensions"
git clone -n --depth=1 --filter=tree:0 -b $BRANCH $FORK_URL
cd $REPO_NAME
git sparse-checkout set --no-cone "extensions/$EXTENSION_NAME"
git checkout
cd "extensions/$EXTENSION_NAME"
npm install && npm run devWe're currently experiencing a high volume of incoming requests. As a result, the initial review may take up to 10-15 business days. |
Greptile OverviewGreptile SummaryThis PR adds an Key Changes:
Issues:
Confidence Score: 4/5
Important Files Changed
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, 1 comment
| <ActionPanel> | ||
| <ActionPanel.Section> | ||
| <Action title="Open Folder" onAction={openResult} /> | ||
| <Action.OpenWith path={searchResult.originalPath} shortcut={{ modifiers: ["cmd"], key: "o" }} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New action should be appended to the end of the section, not inserted as second item. This changes the action order that existing users are familiar with.
Context Used: Rule from dashboard - What: New action panel actions should be appended to the end of the list and prompt users before cha... (source)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mrpunkin thoughts on making this first?
cc: @josiahwiebe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@0xdhrv Personally I think the default action of opening the folder with the default application should remain first in the list. I don't have any problem though with "Open With" taking the second slot despite the valid concern greptile raised.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed.
|
@josiahwiebe Love it. If you wouldn't mind adding to the |
|
Thanks! Just tested and this works great, good addition. Hopefully it won't take too long to get reviewed and merged. |
…age-lock.json - Changed date format for "Added Additional Open With Action" entry in CHANGELOG.md - Marked several dependencies as peer in package-lock.json
|
@josiahwiebe This looks good to me. Can you check it over, and then I’ll merge it? |
|
LGTM. My bad on messing up that changelog format, I thought the placeholder was for humans, not for machines. 😂 |
0xdhrv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, approved 🔥
|
Published to the Raycast Store: |
|
🎉 🎉 🎉 We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag. |
Description
I don't know why I didn't think of using Zoxide via Raycast before, but here we are!
This PR simply adds an additional "open with" action to the actions pane, allowing you to open a directory in something other than your configured default.
Checklist
npm run buildand tested this distribution build in Raycastassetsfolder are used by the extension itselfREADMEare located outside the metadata folder if they were not generated with our metadata tool