Skip to content

Conversation

@LitoMore
Copy link
Contributor

@LitoMore LitoMore commented Jan 31, 2026

Description

Resolves #24974

  • Add support for changing copy action to paste
  • Bump all dependencies to the latest

Checklist

@raycastbot raycastbot added extension fix / improvement Label for PRs with extension's fix improvements extension: simple-icons Issues related to the simple-icons extension platform: macOS platform: Windows OP is author The OP of the PR is the author of the extension labels Jan 31, 2026
@raycastbot
Copy link
Collaborator

Thank you for the update! 🎉

We're currently experiencing a high volume of incoming requests. As a result, the initial review may take up to 10-15 business days.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 31, 2026

Greptile Overview

Greptile Summary

This PR adds a new user preference (usePasteInsteadOfCopy) to swap clipboard-copy behavior for paste-oriented actions, and refactors multiple existing copy actions (including metadata tag clicks) to use a shared helper. It also bumps dependencies/devDependencies and updates the changelog accordingly.

Main issues to address are in src/utils.ts: an unused/likely-invalid React import (use) and a missing await when calling the new async helper from copySvg, which can lead to inconsistent HUD/toast behavior. There’s also an inconsistency in CopyPath where the action title/behavior no longer clearly reflects copy/paste and doesn’t follow the new preference like the other actions.

Confidence Score: 3/5

  • This PR is generally safe to merge after fixing a couple of clear correctness issues in the new copy/paste helper wiring.
  • Most changes are straightforward refactors and dependency bumps, but src/utils.ts introduces an unused React import that can fail lint/TS, and copySvg calls an async function without awaiting it, which can cause flaky UX and unhandled promise issues.
  • extensions/simple-icons/src/utils.ts; extensions/simple-icons/src/actions.tsx

Important Files Changed

Filename Overview
extensions/simple-icons/CHANGELOG.md Adds an [Enhancement] entry with {PR_MERGE_DATE} for the new paste-vs-copy preference and dependency bumps.
extensions/simple-icons/package-lock.json Updates lockfile for bumped @raycast/api, got, lodash, pacote, eslint, prettier, etc.; no functional logic changes.
extensions/simple-icons/package.json Adds a new checkbox preference (Use Paste Instead of Copy) and bumps dependencies/devDependencies.
extensions/simple-icons/src/actions.tsx Introduces CopyOrPaste wrapper and updates multiple actions to paste instead of copy based on preference; CopyPath title/behavior looks inconsistent.
extensions/simple-icons/src/index.tsx Refactors metadata TagList item actions to use shared copyOrPaste helper instead of inline Clipboard.copy+HUD calls.
extensions/simple-icons/src/utils.ts Adds usePasteInsteadOfCopy preference and copyOrPaste helper; introduces an unused/invalid React import and a missing await in copySvg.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6 files reviewed, 4 comments

Edit Code Review Agent Settings | Greptile

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 31, 2026

Additional Comments (1)

extensions/simple-icons/src/utils.ts
[P2] Preference type should be auto-generated; avoid manually typing getPreferenceValues

getPreferenceValues<ExtensionPreferences>() relies on a manually-defined ExtensionPreferences type (not shown here), which can drift from package.json and violates the repo guideline that preference types are auto-generated in raycast-env.d.ts. Prefer getPreferenceValues<Preferences>() (generated) and avoid maintaining a separate preferences interface.

Severity depends on whether ExtensionPreferences is manually declared in this extension (if so, it’s worth removing).

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

@LitoMore LitoMore force-pushed the brand-icons/allow-paste branch from 6d26527 to fcea18c Compare January 31, 2026 16:07
@LitoMore LitoMore force-pushed the brand-icons/allow-paste branch from fcea18c to 004382a Compare January 31, 2026 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

extension fix / improvement Label for PRs with extension's fix improvements extension: simple-icons Issues related to the simple-icons extension OP is author The OP of the PR is the author of the extension platform: macOS platform: Windows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Brand Icons - simpleicons.org] Add paste svg string action

2 participants