TCXB8-3707: Parental Controls blocks false positives #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reason for change: Parental control block on access with certain keywords cause false positives. User intended to block websites like matchweed.com, catchherb.co with keyword "thc", "bc". Along with these, any url with substring "thc" also gets blocked. Change: Keyword search is done on the full string with kmp algorithm. Since no limit is mentioned, the default of 65535 is considered as upper limit of packet payload size for kmp algorithm search. This is restricted to have an upper limit of upto 128 bytes for keyword search. Also, search is limited to the host part of the url for keyword match instead of full url match. Recommendation to user: Avoid very short generic query keywords for blocking Test Procedure: Validate IPTV playback Priority: P1 Risks: None Signed-off-by: nagalakshmi_venkataraman@comcast.com
Contributor
Contributor
|
b'## WARNING: A Blackduck scan failure has been waived A prior failure has been upvoted
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TCXB8-3707: Parental Controls blocks false positives
Reason for change: Parental control block on access with certain keywords cause false positives. User intended to block websites like matchweed.com, catchherb.co with keyword "thc", "bc". Along with these, any url with substring "thc" also gets blocked.
Change: Keyword search is done on the full string with kmp algorithm. Since no limit is mentioned, the default of 65535 is considered as upper limit of packet payload size for kmp algorithm search. This is restricted to have an upper limit of upto 128 bytes for keyword search. Also, search is limited to the host part of the url for keyword match instead of full url match.
Recommendation to user: Avoid very short generic query keywords for blocking
Test Procedure: Validate IPTV playback
Priority: P1
Risks: None
Signed-off-by: nagalakshmi_venkataraman@comcast.com