Skip to content

Conversation

@salmankhann
Copy link

No description provided.

@svnm
Copy link
Member

svnm commented Apr 11, 2017

Hey @salmankhann thanks for your work on this. Unfortunately I would need to change a few things in this pr, so it might be best to discuss your ideas for enhancing it, and plan a few of the enhancements.

  • We would prefer to have the component be less reliant on dom nodes so it works well with rendering to string serversider. So using dangerouslySetInnerHTML would not be a good idea.

  • I think the tick interval needs to be 1000 for this to work correctly as a count down? We might need to do some more research on the math, it has been awhile since I set this up.

Thanks, Steven

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants