-
-
Notifications
You must be signed in to change notification settings - Fork 131
Replace 3rd party domains in examples with example.com #263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace 3rd party domains in examples with example.com #263
Conversation
|
When this PR is approved and merged I'll file PR's for the other repositories that use 3rd party domains for things like this. But until then, the aim is to keep the discussion about this in one location. |
|
Why not use the canonical documentation domains provided by IANA? e.g. www.example.com, www.example.org. That's what they're there for. |
|
@Bilge Good point, but I don't really see a big difference in using |
|
@SimonFrings To be honest I think @Bilge's point is pretty good that those domains are specifically for this purpose. So I'm leaning more to use |
|
@WyriHaximus Fine by me 👍 |
4ec7b94 to
ed5ba82
Compare
|
Updated the PR changing everything to |
SimonFrings
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last question, should it be www.example.com or just example.com. Just asking because PR title doesn't match your changes (pls don't hate me 😅)
ed5ba82 to
6f3c6ea
Compare
|
@SimonFrings It was mainly about updating the domain name, but updated the PR title and commit message 👍 . If you prefer to have it fully in line, I can also update the branch name and file a new PR from that 😜. |
|
Can you guys quit bikeshedding in my feed already. |
SimonFrings
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Goodbye google 👍
While using a big tech 3rd party domain like google.com is guaranteed to work, there are special domains like example.com set up for this since the dawn of the internet.
6f3c6ea to
e72f139
Compare
clue
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@WyriHaximus Thank you for looking into this and updating to example.com! ![]()
While using a big tech 3rd party domain like google.com is guaranteed to work, there are special domains like example.com set up for this since the dawn of the internet.