Skip to content

Conversation

@WyriHaximus
Copy link
Member

@WyriHaximus WyriHaximus commented Jan 11, 2023

While using a big tech 3rd party domain like google.com is guaranteed to work, there are special domains like example.com set up for this since the dawn of the internet.

@WyriHaximus WyriHaximus added this to the v1.4.0 milestone Jan 11, 2023
@WyriHaximus
Copy link
Member Author

When this PR is approved and merged I'll file PR's for the other repositories that use 3rd party domains for things like this. But until then, the aim is to keep the discussion about this in one location.

@Bilge
Copy link

Bilge commented Jan 11, 2023

Why not use the canonical documentation domains provided by IANA? e.g. www.example.com, www.example.org. That's what they're there for.

@SimonFrings
Copy link
Member

@Bilge Good point, but I don't really see a big difference in using www.example.com, www.example.org or reactphp.org. That's why I leave that decision up to @WyriHaximus and will approve whatever he decides :D

@WyriHaximus
Copy link
Member Author

@SimonFrings To be honest I think @Bilge's point is pretty good that those domains are specifically for this purpose. So I'm leaning more to use example.com then to use reactphp.org at this point. Unless @clue has good reasons to go with either of those two.

@SimonFrings
Copy link
Member

@WyriHaximus Fine by me 👍

@WyriHaximus WyriHaximus force-pushed the 1.x-replace-google.com-with-reactphp.org branch from 4ec7b94 to ed5ba82 Compare January 21, 2023 20:43
@WyriHaximus WyriHaximus changed the title Replace 3rd party domains in examples with reactphp.org Replace 3rd party domains in examples with example.com Jan 21, 2023
@WyriHaximus
Copy link
Member Author

Updated the PR changing everything to example.com

Copy link
Member

@SimonFrings SimonFrings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last question, should it be www.example.com or just example.com. Just asking because PR title doesn't match your changes (pls don't hate me 😅)

@WyriHaximus WyriHaximus changed the title Replace 3rd party domains in examples with example.com Replace 3rd party domains in examples with www.example.com Jan 25, 2023
@WyriHaximus WyriHaximus force-pushed the 1.x-replace-google.com-with-reactphp.org branch from ed5ba82 to 6f3c6ea Compare January 25, 2023 07:27
@WyriHaximus
Copy link
Member Author

@SimonFrings It was mainly about updating the domain name, but updated the PR title and commit message 👍 . If you prefer to have it fully in line, I can also update the branch name and file a new PR from that 😜.

@Bilge
Copy link

Bilge commented Jan 25, 2023

Can you guys quit bikeshedding in my feed already.

Copy link
Member

@SimonFrings SimonFrings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Goodbye google 👍

@WyriHaximus WyriHaximus changed the title Replace 3rd party domains in examples with www.example.com Replace 3rd party domains in examples with example.com May 2, 2023
While using a big tech 3rd party domain like google.com is guaranteed to work, there are special domains like example.com set up for this since the dawn of the internet.
@WyriHaximus WyriHaximus force-pushed the 1.x-replace-google.com-with-reactphp.org branch from 6f3c6ea to e72f139 Compare May 2, 2023 12:37
Copy link
Member

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WyriHaximus Thank you for looking into this and updating to example.com! :shipit:

@clue clue merged commit a78ae0b into reactphp:1.x May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants