Button Code Rewrite #118
Open
Button Code Rewrite #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KasparByrne
commented
Sep 13, 2024
KasparByrne
commented
- Added using standard mqtt client code (Drivers/lib/mqtt_client.py) instead of creating new mqtt client
- Added logging
- Added using ArgumentParser from script
- Create Button class for reusable button code
- Added publishing button values & info using JSON
- Changed to using event listener for button presses & releases over previous loop & check
- Created new MQTT topic for all buttons: bike/{DEVICE_ID}/button
- Updated lib/mqtt_client.py to use logging & take port argument
- Moved button code into driver under directory "button_control"
-Now uses Drivers/lib/mqtt_client.py MQTT client code instead of own.
-Rewrote most code to use event listening for button presses instead of looping & sleeping
-Moved button code into own driver folder: button_control
-Created new MQTT topic - bike/{ID}/button - for button communication.
-Now uses parsed arguments from script with defaulting to environment variables rather than hardcoded values.
-Changed to use report sub-topic instead of control sub-topic as the buttons only "sense"
- turns out there was a much cleaner way to import the mqtt_client from lib.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.