-
Notifications
You must be signed in to change notification settings - Fork 63
feat: RHIDP-9768 catalog index support #149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: RHIDP-9768 catalog index support #149
Conversation
Signed-off-by: Fortune Ndlovu <fndlovu@redhat.com>
Signed-off-by: Fortune Ndlovu <fndlovu@redhat.com>
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR TypeEnhancement, Documentation Description
|
| Relevant files | |||
|---|---|---|---|
| Configuration changes |
| ||
| Documentation |
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
|||||||||
Signed-off-by: Fortune Ndlovu <fndlovu@redhat.com>
rm3l
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Description
This PR adds catalog-index-support to rhdh local, by adding the
CATALOG_INDEX_IMAGEenv var withindefault.envwe allow theinstall-dynamic-pluginsservice to use it when the container is being created so by the time we run the install-dynamic-plugins.py inside the container, it can be detected.Which issue(s) does this PR fix or relate to
PR acceptance criteria
How to test changes / Special notes to the reviewer