-
Notifications
You must be signed in to change notification settings - Fork 63
docs: add private registry documentation #151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
docs: add private registry documentation #151
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR TypeDocumentation Description
|
| Relevant files | |||
|---|---|---|---|
| Documentation |
|
5aa551b to
9eeb60e
Compare
PR Code Suggestions ✨Explore these optional code suggestions:
|
Signed-off-by: Tomas Kral <tkral@redhat.com> Assisted-by: Claude Code
9eeb60e to
b2e13c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should move this to the already existing https://github.com/redhat-developer/rhdh-local/blob/main/docs/rhdh-local-guide/container-image-guide.md because the existing REGISTRY_AUTH_FILE approach seems to be correct however, using existing local credentials without copying is also valid. I'd suggest extending the existing docs in container-image-guide.md to show both options, wdyt?
| Add the following volume to the `install-dynamic-plugins` service in `compose.yaml`: | ||
|
|
||
| ```yaml | ||
| install-dynamic-plugins: | ||
| volumes: | ||
| # ... existing volumes ... | ||
| - ~/.config/containers/auth.json:/opt/app-root/src/.config/containers/auth.json:Z | ||
| ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this requires modifying a version-controlled file, which I believe we are striving to avoid as much as possible for users.
Not tested, but I wonder if we could not actually add this by default as a configurable bind mount in the current compose.yaml:
install-dynamic-plugins:
volumes:
# ... existing volumes ...
- ${REGISTRY_AUTH_FILE_PATH:-./configs/registry-auth.example.json}:/opt/app-root/src/.config/containers/auth.example.json:ZAdding a default value to mount an example empty auth file, so that this is optional.
But assuming skopeo will fail if the auth.json file is not valid json, I guess we can maybe do some special handling in the prepare-and-install-dynamic-plugins.sh script to copy /opt/app-root/src/.config/containers/auth.example.json to /opt/app-root/src/.config/containers/auth.json if REGISTRY_AUTH_FILE_PATH is set in the env.
With this, users would only need to set the REGISTRY_AUTH_FILE_PATH in their local .env file.
WDYT?
|
|
||
| > **NOTE**: The location of `auth.json` may vary depending on your system configuration. Common locations include: | ||
| > | ||
| > - `~/.config/containers/auth.json` (Podman default) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the default value for Podman is ${XDG_RUNTIME_DIR:-~/.config}/containers/auth.json (at least on Linux): https://docs.podman.io/en/latest/markdown/podman-login.1.html#description
Description
Add documentation describing how to access plugins in private container/oci registries
PR acceptance criteria
How to test changes / Special notes to the reviewer