Skip to content

Fix homepage template kind chip #2110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Eswaraiahsapram wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix homepage template kind chip #2110

Eswaraiahsapram wants to merge 1 commit into from
+16 −11

Conversation

@Eswaraiahsapram
Copy link
Member

@Eswaraiahsapram Eswaraiahsapram commented Jan 20, 2026 •
edited
Loading

Hey, I just made a Pull Request!

Resolves - https://issues.redhat.com/browse/RHDHBUGS-2197

Screenshot
image

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or Updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)

@rhdh-gh-app
Copy link

rhdh-gh-app bot commented Jan 20, 2026 •
edited
Loading

Changed Packages

Package Name Package Path Changeset Bump Current Version
@red-hat-developer-hub/backstage-plugin-dynamic-home-page workspaces/homepage/plugins/dynamic-home-page patch v1.10.3

@Eswaraiahsapram Eswaraiahsapram force-pushed the fix-homepage-template-kind-chip branch from 0b5b89d to 3f39532 Compare January 20, 2026 05:02
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 20, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

lokanandaprabhu
lokanandaprabhu approved these changes Jan 20, 2026
View reviewed changes
Copy link
Member

@lokanandaprabhu lokanandaprabhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 20, 2026
@ShiranHi
Copy link

ShiranHi commented Jan 20, 2026

@Eswaraiahsapram looks great! Just one question:
Do the template tags already reflect the category (such as 'service' or 'website') in a way that matches the Backstage demo here?

@Eswaraiahsapram
Copy link
Member Author

Eswaraiahsapram commented Jan 20, 2026

@Eswaraiahsapram looks great! Just one question: Do the template tags already reflect the category (such as 'service' or 'website') in a way that matches the Backstage demo here?

@ShiranHi , at the moment we are only displaying the template tag. The category (for example, service or website) is not being shown yet.

@ShiranHi
Copy link

ShiranHi commented Jan 22, 2026

@ShiranHi , at the moment we are only displaying the template tag. The category (for example, service or website) is not being shown yet.

Basically yes, if this is not a lot of work, "Template" alone doesn't give users enough information to differentiate them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lokanandaprabhu lokanandaprabhu lokanandaprabhu approved these changes

@christoph-jerolimov christoph-jerolimov Awaiting requested review from christoph-jerolimov christoph-jerolimov is a code owner

@its-mitesh-kumar its-mitesh-kumar Awaiting requested review from its-mitesh-kumar

@ShiranHi ShiranHi Awaiting requested review from ShiranHi

Assignees

@lokanandaprabhu lokanandaprabhu

Labels

lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Eswaraiahsapram @ShiranHi @lokanandaprabhu