fix: remove Ansible Lab type entries to prevent broken links #4014
Conversation
|
Hi @sshedmake. Thanks for your PR. I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
sshedmake
changed the title
sshedmake
force-pushed
the
remove-ansible-lab
branch
from
3515318 to
4ad0c6e
Compare
sshedmake
changed the title
sshedmake
changed the title
sshedmake
force-pushed
the
remove-ansible-lab
branch
from
4ad0c6e to
1519d06
Compare
|
Can you give me a bit more context. |
|
The image is available at: /test e2e-ocp-helm |
|
@github-actions[bot]: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Get
Here's a sample screenshot of broken Ansible Lab link (upon clicking https://red.ht/aap-lab-sign-collections-with-pah) : Thereby, this PR intends to remove the above static Ansible Lab links from the code-base. Reference: the same has been removed from Ansible plugins for RHDH public upstream repository via PR |
alizard0
left a comment
alizard0
left a comment
There was a problem hiding this comment.
After speaking with @sshedmake , I understood the context of this PR
https://issues.redhat.com/browse/AAP-58481
/lgtm
sshedmake
force-pushed
the
remove-ansible-lab
branch
from
79fc47b to
0e350ec
Compare
|
/retest |
|
@sshedmake: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
sshedmake
force-pushed
the
remove-ansible-lab
branch
from
0e350ec to
a7ac98d
Compare
|
/retest |
|
/retest /lgtm /approve |
|
@alizard0: The The following commands are available to trigger optional jobs: Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alizard0, audgirka The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
|
/ok-to-test |
1 similar comment
|
/ok-to-test |
|
/retest |
|
/ok-to-test |
|
@sshedmake: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
Description
Remove static Ansible Lab links to prevent broken links and user confusion when labs are taken offline.
Changes
Removed all 4 occurrences of
"type": "Ansible Lab"frompackages/app/public/learning-paths/data.jsonAffected Entries
The following learning path entries would be removed:
Testing
How to test changes / Special notes to the reviewer
Additional info: Please see ansible/ansible-backstage-plugins#48