chore(e2e): adding localization to nightly jobs #4020
Conversation
Signed-off-by: Sanket Saikia <sanketsaikia13@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR TypeEnhancement, Tests Description
|
| Relevant files | |||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Enhancement |
| ||||||||||||||
| Documentation |
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
||||||||||||
|
/test e2e-ocp-helm-nightly |
|
The image is available at: /test e2e-ocp-helm |
|
/test e2e-ocp-helm-nightly |
|
The image is available at: /test e2e-ocp-helm |
openshift-ci
bot
requested review from
HusneShabbir,
jrichter1 and
sanketpathak
Signed-off-by: Sanket Saikia <sanketsaikia13@gmail.com>
|
/test e2e-ocp-helm-nightly |
|
The image is available at: /test e2e-ocp-helm |
|
/test e2e-ocp-helm |
zdrapela
left a comment
zdrapela
left a comment
There was a problem hiding this comment.
The logic to run the tests looks good. We need to have CI fixed to verify everything works smoothly. I've seen failed tests in https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/redhat-developer_rhdh/4020/pull-ci-redhat-developer-rhdh-main-e2e-ocp-helm-nightly/2013461772190617600/artifacts/e2e-ocp-helm-nightly/redhat-developer-rhdh-ocp-helm-nightly/artifacts/showcase/index.html, but I'm not sure if it's caused by your test.
Anyway, I found some issues that are not a problem of this PR, but more of the code base. Please see my inline comments and let me know if you are up for fixing them or if I should rather take a look. I hope I explained myself well, but let me know if something is not clear 😉
| ### Step 4: Validate Files | ||
|
|
||
| ```bash | ||
| # Navigate to marketplace directory |
There was a problem hiding this comment.
Thanks! I’ve already regenerated the RuleSync files and committed the updates.
There was a problem hiding this comment.
Please push the updates. I don't see them here yet
.ibm/pipelines/jobs/ocp-nightly.sh
Outdated
| local url="https://${RELEASE_NAME}-developer-hub-${NAME_SPACE}.${K8S_CLUSTER_ROUTER_BASE}" | ||
| log::section "Running localization tests" | ||
| # French (fr) | ||
| check_and_test "${RELEASE_NAME}" "${NAME_SPACE}" "${PW_PROJECT_SHOWCASE_LOCALIZATION_FR}" "${url}" |
There was a problem hiding this comment.
I found an issue caused by my oversight in #3796 😅
The run_tests function is using namespace as a hardcoded folder to store artifacts in the root ARTIFACTS_DIR. This leads to overriding the results from the showcase project by the results of your localization tests. See https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/redhat-developer_rhdh/4020/pull-ci-redhat-developer-rhdh-main-e2e-ocp-helm-nightly/2013461772190617600/artifacts/e2e-ocp-helm-nightly/redhat-developer-rhdh-ocp-helm-nightly/artifacts/showcase/index.html
To fix that, I suggest doing something like this: zdrapela@faa4103 We want to keep the default value bound to the namespace, but in your case, we need to override it with PW_PROJECT_SHOWCASE_LOCALIZATION_FR - see my suggestion.
| check_and_test "${RELEASE_NAME}" "${NAME_SPACE}" "${PW_PROJECT_SHOWCASE_LOCALIZATION_FR}" "${url}" | |
| check_and_test "${RELEASE_NAME}" "${NAME_SPACE}" "${PW_PROJECT_SHOWCASE_LOCALIZATION_FR}" "${url}" "${PW_PROJECT_SHOWCASE_LOCALIZATION_FR}" |
Are you up for fixing it in your PR, or should I open a separate one to fix it?
There was a problem hiding this comment.
We can fix it here, or another PR, anything is fine by me.
There was a problem hiding this comment.
Okay, please try it here and we will see if that works well
|
🚫 Image Push Skipped. The container image push was skipped because the build was skipped (either due to [skip-build] tag or no relevant changes with existing image) |
|
/test e2e-ocp-helm-nightly |
|
/test e2e-ocp-helm-nightly |
|
The image is available at: |
|
|
The image is available at: |
|
/test e2e-ocp-helm-nightly |
|
@teknaS47: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
zdrapela
left a comment
zdrapela
left a comment
There was a problem hiding this comment.
The PR looks good, but we need to wait for the fix of the PR checks to verify it.
zdrapela
left a comment
zdrapela
left a comment
There was a problem hiding this comment.
The PR looks good, but we need to wait for the fix of the PR checks to verify it.
3 participants
Description
Adding localization tests for other locales to the ocp-helm-nightly job
Which issue(s) does this PR fix
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer