Skip to content

Conversation

@zdrapela
Copy link
Member

@zdrapela zdrapela commented Jan 22, 2026

Description

Add GITHUB_TOKEN to avoid rate limiting while downloading ShellCheck binary

Which issue(s) does this PR fix

  • Fixes #?

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

Add GITHUB_TOKEN to avoid rate limiting while downloading ShellCheck binary

Assisted-by: Cursor
@openshift-ci
Copy link

openshift-ci bot commented Jan 22, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link

openshift-ci bot commented Jan 22, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign schultzp2020 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zdrapela zdrapela marked this pull request as ready for review January 22, 2026 13:04
@openshift-ci openshift-ci bot requested review from polasudo and rm3l January 22, 2026 13:04
@github-actions
Copy link
Contributor

@openshift-ci
Copy link

openshift-ci bot commented Jan 22, 2026

@zdrapela: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ocp-helm c6a5acd link true /test e2e-ocp-helm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

This reverts commit c6a5acd.
@sonarqubecloud
Copy link

@zdrapela
Copy link
Member Author

/review
-i

@rhdh-qodo-merge
Copy link

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🔒 No security concerns identified
⚡ Recommended focus areas for review

Token usage

Validate that using secrets.GITHUB_TOKEN is correct for this workflow. In GitHub Actions, the built-in token is typically accessed via github.token (or is already available to API clients), and secrets.GITHUB_TOKEN may be redundant or behave differently in some contexts. Confirm the ShellCheck download logic actually reads GITHUB_TOKEN from env and that this change resolves the rate limiting.

env:
  GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: yarn shellcheck
Permissions

Ensure the workflow’s permissions: are appropriately scoped for the added token usage (principle of least privilege). If the token is only needed for authenticated downloads, consider explicitly setting minimal permissions (e.g., contents: read) at the workflow/job level to avoid granting more access than required.

env:
  GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: yarn shellcheck
📄 References
  1. redhat-developer/rhdh-chart/charts/orchestrator-software-templates-infra/templates/openshift-gitops/argocd-credential-template.yaml [0-2]
  2. redhat-developer/rhdh-chart/charts/orchestrator-software-templates/templates/tekton/tekton-tasks.yaml [45-52]
  3. redhat-developer/rhdh-operator/config/profile/rhdh/plugin-deps/tekton.yaml [45-52]
  4. redhat-developer/rhdh-chart/charts/orchestrator-software-templates/templates/tekton/tekton-tasks.yaml [117-151]
  5. redhat-developer/rhdh-operator/config/profile/rhdh/plugin-deps/tekton.yaml [117-151]
  6. redhat-developer/rhdh-chart/charts/orchestrator-software-templates/templates/tekton/tekton-tasks.yaml [91-116]
  7. redhat-developer/rhdh-operator/config/profile/rhdh/plugin-deps/tekton.yaml [91-116]
  8. redhat-developer/rhdh-chart/charts/orchestrator-software-templates/templates/tekton/tekton-tasks.yaml [1-21]

@github-actions
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants