Feature / admin / dashboard #135
Conversation
… consultation metrics
|
Warning Rate limit exceeded@eraser502 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 12 minutes and 46 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
Walkthrough관리자 대시보드 통계 API가 추가되었습니다. 새 REST 컨트롤러 Sequence DiagramsequenceDiagram
participant Client
participant Controller as AdminDashboardController
participant Service as AdminDashboardService
participant Members as RedotMemberRepository
participant Consults as ConsultationRepository
participant Admins as AdminRepository
Client->>Controller: GET /api/v1/redot/admin/dashboard/stats
Controller->>Service: getDashboardStats()
Service->>Service: compute startOfToday (Asia/Seoul -> UTC)
Service->>Members: count()
Members-->>Service: totalRedotMembers
Service->>Members: countByCreatedAtBefore(startOfTodayUtc)
Members-->>Service: redotMembersUntilYesterday
Service->>Consults: countByStatus(PENDING)
Consults-->>Service: pendingConsultationCount
Service->>Admins: count()
Admins-->>Service: adminCount
Service-->>Controller: AdminDashboardStatsResponse
Controller-->>Client: 200 OK (AdminDashboardStatsResponse)
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Possibly related PRs
Poem
Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
src/main/java/redot/redot_server/domain/admin/service/AdminDashboardService.java (1)
26-31: 데이터 정합성 이상 징후를 로깅하는 것을 고려해보세요.Line 28에서
Math.max를 사용하여 음수 값을 방지하고 있는데, 만약 계산 결과가 음수라면 데이터 정합성에 문제가 있다는 신호일 수 있습니다. 이러한 경우를 로깅하면 향후 디버깅에 도움이 될 수 있습니다.예시:
+ long newRedotMembersSinceYesterday = totalRedotMembers - redotMembersUntilYesterday; + if (newRedotMembersSinceYesterday < 0) { + log.warn("신규 회원 수 계산 결과가 음수입니다. total={}, untilYesterday={}", + totalRedotMembers, redotMembersUntilYesterday); + newRedotMembersSinceYesterday = 0L; + } - long newRedotMembersSinceYesterday = Math.max(0L, totalRedotMembers - redotMembersUntilYesterday);
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
src/main/java/redot/redot_server/domain/admin/controller/AdminDashboardController.java(1 hunks)src/main/java/redot/redot_server/domain/admin/controller/docs/AdminDashboardControllerDocs.java(1 hunks)src/main/java/redot/redot_server/domain/admin/dto/response/AdminDashboardStatsResponse.java(1 hunks)src/main/java/redot/redot_server/domain/admin/service/AdminDashboardService.java(1 hunks)src/main/java/redot/redot_server/domain/redot/member/repository/RedotMemberRepository.java(2 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-12-17T01:39:43.440Z
Learnt from: eraser502
Repo: redotlabs/server PR: 134
File: src/main/java/redot/redot_server/domain/admin/service/AdminRedotAppService.java:58-71
Timestamp: 2025-12-17T01:39:43.440Z
Learning: In the RedotApp domain model, enforce 1:1 relationships: RedotApp must have exactly one Domain, one StyleInfo, and one SiteSetting. Review AdminRedotAppService and related domain entities to ensure constraints reflect this: enforce non-null associations, unique foreign keys or join tables as appropriate, and strict cascade rules. Validate that the database schema enforces one-to-one mappings (unique foreign keys or shared primary keys), and that service layer logic does not permit multiple related entities or optional links for RedotApp. Ensure getters/setters and persistence mappings (annotations or XML) align with a 1:1 relationship pattern and update tests to cover these invariants.
Applied to files:
src/main/java/redot/redot_server/domain/admin/controller/docs/AdminDashboardControllerDocs.javasrc/main/java/redot/redot_server/domain/admin/dto/response/AdminDashboardStatsResponse.javasrc/main/java/redot/redot_server/domain/admin/controller/AdminDashboardController.javasrc/main/java/redot/redot_server/domain/redot/member/repository/RedotMemberRepository.javasrc/main/java/redot/redot_server/domain/admin/service/AdminDashboardService.java
🔇 Additional comments (3)
src/main/java/redot/redot_server/domain/admin/dto/response/AdminDashboardStatsResponse.java (1)
5-12: 잘 구현되었습니다!Java record를 사용한 깔끔한 DTO 구현입니다. 모든 필드에 명확한 Swagger 문서가 작성되어 있고, 불변 데이터 구조로 적절하게 설계되었습니다.
src/main/java/redot/redot_server/domain/admin/controller/docs/AdminDashboardControllerDocs.java (1)
11-18: API 문서화가 잘 되어 있습니다!Swagger 어노테이션을 사용한 명확한 API 문서 작성이 잘 되어 있습니다.
src/main/java/redot/redot_server/domain/admin/controller/AdminDashboardController.java (1)
12-24: 보안 설정이 이미 적용되어 있습니다.이 엔드포인트는 이미 전역 보안 설정으로 보호되고 있습니다. SecurityConfig의 adminApiChain(Order 6)에서
/api/v1/redot/admin/**경로에 대해.authenticated()요구사항이 설정되어 있으며, AdminJwtAuthenticationFilter가 JWT 인증을 처리합니다. 메서드 레벨 어노테이션이 없어도 모든 요청은 유효한 관리자 토큰 없이는 접근할 수 없습니다.Likely an incorrect or invalid review comment.
src/main/java/redot/redot_server/domain/admin/service/AdminDashboardService.java
Outdated
Show resolved
Hide resolved
src/main/java/redot/redot_server/domain/redot/member/repository/RedotMemberRepository.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/main/java/redot/redot_server/domain/redot/consultation/repository/ConsultationRepository.java (1)
9-9: 대시보드 성능 최적화를 위한 인덱스 고려대시보드에서 상태별 집계 쿼리가 자주 호출될 경우,
consultation테이블의status컬럼에 인덱스를 추가하면 쿼리 성능이 향상됩니다. 데이터베이스 마이그레이션에서 인덱스 생성을 검토해주세요.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
src/main/java/redot/redot_server/domain/admin/dto/response/AdminDashboardStatsResponse.java(1 hunks)src/main/java/redot/redot_server/domain/admin/service/AdminDashboardService.java(1 hunks)src/main/java/redot/redot_server/domain/redot/consultation/repository/ConsultationRepository.java(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
- src/main/java/redot/redot_server/domain/admin/dto/response/AdminDashboardStatsResponse.java
- src/main/java/redot/redot_server/domain/admin/service/AdminDashboardService.java
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-12-17T01:39:43.440Z
Learnt from: eraser502
Repo: redotlabs/server PR: 134
File: src/main/java/redot/redot_server/domain/admin/service/AdminRedotAppService.java:58-71
Timestamp: 2025-12-17T01:39:43.440Z
Learning: In the RedotApp domain model, enforce 1:1 relationships: RedotApp must have exactly one Domain, one StyleInfo, and one SiteSetting. Review AdminRedotAppService and related domain entities to ensure constraints reflect this: enforce non-null associations, unique foreign keys or join tables as appropriate, and strict cascade rules. Validate that the database schema enforces one-to-one mappings (unique foreign keys or shared primary keys), and that service layer logic does not permit multiple related entities or optional links for RedotApp. Ensure getters/setters and persistence mappings (annotations or XML) align with a 1:1 relationship pattern and update tests to cover these invariants.
Applied to files:
src/main/java/redot/redot_server/domain/redot/consultation/repository/ConsultationRepository.java
🔇 Additional comments (2)
src/main/java/redot/redot_server/domain/redot/consultation/repository/ConsultationRepository.java (2)
5-5: LGTM!
ConsultationStatusimport가 새로운 메서드 시그니처에 필요하며 올바르게 추가되었습니다.
8-9: [rewritten review comment]
[classification tag]
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
src/main/java/redot/redot_server/domain/admin/service/AdminDashboardService.java(1 hunks)src/main/resources/db/migration/V7__add_index_to_redot_members_created_at.sql(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-12-17T01:39:43.440Z
Learnt from: eraser502
Repo: redotlabs/server PR: 134
File: src/main/java/redot/redot_server/domain/admin/service/AdminRedotAppService.java:58-71
Timestamp: 2025-12-17T01:39:43.440Z
Learning: In the RedotApp domain model, enforce 1:1 relationships: RedotApp must have exactly one Domain, one StyleInfo, and one SiteSetting. Review AdminRedotAppService and related domain entities to ensure constraints reflect this: enforce non-null associations, unique foreign keys or join tables as appropriate, and strict cascade rules. Validate that the database schema enforces one-to-one mappings (unique foreign keys or shared primary keys), and that service layer logic does not permit multiple related entities or optional links for RedotApp. Ensure getters/setters and persistence mappings (annotations or XML) align with a 1:1 relationship pattern and update tests to cover these invariants.
Applied to files:
src/main/java/redot/redot_server/domain/admin/service/AdminDashboardService.java
🔇 Additional comments (3)
src/main/resources/db/migration/V7__add_index_to_redot_members_created_at.sql (1)
1-1: 인덱스 추가가 적절합니다.
created_at컬럼에 대한 인덱스는countByCreatedAtBefore쿼리의 성능을 향상시킵니다.IF NOT EXISTS사용으로 안전하게 마이그레이션이 실행됩니다.src/main/java/redot/redot_server/domain/admin/service/AdminDashboardService.java (2)
15-22: 서비스 구조가 잘 설계되었습니다.읽기 전용 트랜잭션 설정이 적절하며, 필요한 리포지토리들이 올바르게 주입되었습니다.
30-39: 대시보드 통계 로직이 명확합니다.대기 중인 상담 수와 관리자 수를 집계하는 로직이 직관적이며, 응답 객체 구성도 적절합니다. 순차적인 count 쿼리 실행은 관리자 대시보드의 사용 빈도를 고려할 때 허용 가능한 수준입니다.
src/main/java/redot/redot_server/domain/admin/service/AdminDashboardService.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
src/main/java/redot/redot_server/domain/admin/service/AdminDashboardService.java (1)
29-33: 리포지토리 호출에 대한 예외 처리를 고려해주세요.여러 리포지토리를 순차적으로 호출하고 있지만, 예외 처리가 없습니다. 특정 통계 조회가 실패하더라도 다른 통계는 반환할 수 있도록 하거나, 최소한 의미 있는 에러 메시지를 제공하는 것이 좋습니다.
예를 들어:
public AdminDashboardStatsResponse getDashboardStats() { try { // ... 기존 로직 ... } catch (Exception e) { log.error("Failed to fetch dashboard statistics", e); throw new DashboardException("대시보드 통계를 조회하는 중 오류가 발생했습니다", e); } }
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/main/java/redot/redot_server/domain/admin/service/AdminDashboardService.java(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-12-17T01:39:43.440Z
Learnt from: eraser502
Repo: redotlabs/server PR: 134
File: src/main/java/redot/redot_server/domain/admin/service/AdminRedotAppService.java:58-71
Timestamp: 2025-12-17T01:39:43.440Z
Learning: In the RedotApp domain model, enforce 1:1 relationships: RedotApp must have exactly one Domain, one StyleInfo, and one SiteSetting. Review AdminRedotAppService and related domain entities to ensure constraints reflect this: enforce non-null associations, unique foreign keys or join tables as appropriate, and strict cascade rules. Validate that the database schema enforces one-to-one mappings (unique foreign keys or shared primary keys), and that service layer logic does not permit multiple related entities or optional links for RedotApp. Ensure getters/setters and persistence mappings (annotations or XML) align with a 1:1 relationship pattern and update tests to cover these invariants.
Applied to files:
src/main/java/redot/redot_server/domain/admin/service/AdminDashboardService.java
🔇 Additional comments (2)
src/main/java/redot/redot_server/domain/admin/service/AdminDashboardService.java (2)
15-22: 클래스 구조가 잘 구성되어 있습니다.Spring 서비스 어노테이션, 읽기 전용 트랜잭션, 그리고 생성자 주입이 적절하게 적용되었습니다.
25-27: 타임존 처리 개선이 잘 적용되었습니다.이전 리뷰에서 지적된
ZoneId.systemDefault()사용 문제가 명시적인Asia/Seoul타임존 사용으로 개선되었습니다. UTC로의 변환도 명확하게 처리되었습니다.
Overview
Related Issue
PR Checklist
Additional Information