Hamza robot homework #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remarcmij
requested changes
Jan 12, 2018
Owner
remarcmij
left a comment
remarcmij
left a comment
There was a problem hiding this comment.
Almost there! There is still one bug: I still get a Yum when the robot has moved beyond the apples and when reaching the flag. I should only get Yum's when passing over an apple.
The pull request itself has now the correct branch.
| @@ -1,21 +1,22 @@ | |||
| (function () { | |||
| ((function () { | |||
Owner
There was a problem hiding this comment.
You don't need these extra parentheses. As I explained earlier this is sufficient:
(function () {
// all your other code
})();| y: 0, | ||
| dir: 'up', | ||
| y: 2, | ||
| dir: 'down', |
Owner
There was a problem hiding this comment.
The initial direction of the robot in the example is 'right'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hello teacher Could you please accept my pull request