anas almostafa #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remarcmij
approved these changes
Jan 12, 2018
Owner
remarcmij
left a comment
remarcmij
left a comment
There was a problem hiding this comment.
Excellent work. Fully meets the requirements of the assignment.
| const cellContents = board[y][x]; | ||
|
|
||
| if (cellContents === '.' || cellContents === 'F') { | ||
| if (cellContents === '.' || cellContents === 'F' || cellContents==='A') { |
Owner
There was a problem hiding this comment.
Add a space before and after the ===. This happens automatically if you use the Format Document command in VSCode.
| board[y][x] = 'R'; | ||
| if (cellContents === 'A') { | ||
| appleEaten = true; | ||
| applesEaten ++; |
Owner
There was a problem hiding this comment.
It is customary to append the ++ (or --) directly to the variable to which it applies (without an intervening space).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope my work is right.